Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): deactivate useless linter warnings for yaml document start #13688

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Aug 22, 2022

The document start is really a big pain and only bloats the files. This the yaml linter for it is deactivated with this commit.

This PR is required for a PR coming to add copyright headers (#13280). The PR will be opened if this one is merged, to avoid the heaps of annotations, which would be generated otherwise.

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 22, 2022
@Neudrino Neudrino marked this pull request as ready for review August 22, 2022 17:29
@Neudrino Neudrino requested a review from a team as a code owner August 22, 2022 17:29
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 83cf1da.

@Neudrino Neudrino changed the title feat(ci): deactivate useless linter warnings for document start feat(ci): deactivate useless linter warnings for yaml document start Aug 22, 2022
@Neudrino Neudrino enabled auto-merge (squash) August 22, 2022 17:36
Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

  • Do you plan to re-enable the check or is it permanently turned off?
    • If it is permanent then perhaps we should clean up the document start markers and make them uniform in all files as a follow up task.

@Neudrino Neudrino merged commit 4302ef4 into magma:master Aug 23, 2022
@Neudrino Neudrino deleted the ci/update-yaml-linter branch August 23, 2022 07:00
@Neudrino
Copy link
Contributor Author

Neudrino commented Aug 23, 2022

  • If it is permanent then perhaps we should clean up the document start markers and make them uniform in all files as a follow up task.

Yes. This was already prepared with #13696, but could not be opened, until the first one was merged. Otherwise it would have been swamped with linter warnings. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants