chore(ci): Mitigate Vagrant cloud rate limiting errors by logging in

[LKreutzer]

Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com
Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

• Log in to the vagrant cloud to mitigate rate limiting - this measure does not always work - which is why the caching is still needed.
• Vagrant cloud API docs: https://www.vagrantup.com/docs/cli/login
• The login persists across workflow steps.
  • This can be checked with: vagrant login --check
  • See testing run with these changes (aborted after successful log in steps and check).
• The secret VAGRANT_TOKEN was created by Fabio Palumbo.

Test Plan

• Test login on fork (with testing secret with the same name)
  Successful log in (this is the expected output):
  

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 9a95478.

♻️ This comment has been updated with latest results.

[LKreutzer]

• Needs to be confirmed that the secret exists on magma/master @maxhbr

[nstng]

making sure this is not merged before secret is on magma

[nstng]

from discussion: please check behavior on forks if secret is not present

[LKreutzer]

from discussion: please check behavior on forks if secret is not present
@nstng added if conditional to check that the secret exists (tested the conditional in dummy workflow).