Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Add missing paths to the path filter in the bazel workflow #13735

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix(ci): Add missing paths to the path filter in the bazel workflow #13735

merged 1 commit into from
Aug 25, 2022

Conversation

LKreutzer
Copy link
Contributor

Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com
Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer
fix(ci): Add missing paths to the path filter in the bazel workflow
fbf8950 
Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 25, 2022
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Aug 25, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@LKreutzer LKreutzer marked this pull request as ready for review August 25, 2022 13:46
@LKreutzer LKreutzer requested review from a team and jheidbrink August 25, 2022 13:46
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit fbf8950.

nstng
nstng approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nstng nstng merged commit c1b0cb6 into magma:master Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstng nstng nstng approved these changes

@jheidbrink jheidbrink Awaiting requested review from jheidbrink

Assignees

@LKreutzer LKreutzer

@vktng vktng

Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel Build & Test Job does not run when '.bazelrc' or 'WORKSPACE.bazel' files are modified
3 participants
@LKreutzer @nstng @vktng