Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix debug logging for bazel dependency #13747

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

LKreutzer
Copy link
Contributor

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Bazel suggests a certain format for the shallow_since property, this is adopted to get rid of the debug logging:
Screenshot from 2022-08-26 11-02-11

Test Plan

Additional Information

  • This change is backwards-breaking

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added the bazel changes for the Bazelification effort label Aug 26, 2022
@LKreutzer LKreutzer self-assigned this Aug 26, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@LKreutzer LKreutzer marked this pull request as ready for review August 26, 2022 09:10
@LKreutzer LKreutzer requested review from a team and vktng August 26, 2022 09:10
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b4429a5.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thx, this was bugging me too

@LKreutzer LKreutzer merged commit 7a6e85c into magma:master Aug 26, 2022
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants