Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): Increase disk size for agw vm #13750

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

crasu
Copy link
Contributor

@crasu crasu commented Aug 26, 2022

Summary

Disk size for agw containers was increased to 75GB to accomdate build of dockerized agw containers. Vagrant cannot
handle file system resizing for the container - probably because it uses lvm.

Test Plan

Tested increased container size locally. You need to remove all your vms from virtualbox (including the base vm virtualboxes uses for quicker vm setup) to test this.

AGW integ run: https://github.com/crasu/magma/actions/workflows/lte-integ-test.yml

@crasu crasu requested a review from a team August 26, 2022 11:28
@crasu crasu requested review from a team as code owners August 26, 2022 11:28
@crasu crasu requested review from voisey, koolzz and nstng August 26, 2022 11:28
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue labels Aug 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 66005e9.

♻️ This comment has been updated with latest results.

@crasu crasu force-pushed the pr/increase-agw-disk-size-for-containers branch from f029a29 to aef6f56 Compare August 26, 2022 11:37
@crasu crasu changed the title chore(agw): Increase disksize for agw vm chore(agw): Increase disk size for agw vm Aug 26, 2022
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is the disk-size for the VMs dynamically allocated?
  • Depending on the above, this might also be an anti-feature if you are developing on a system with limited hard disk space.
  • If docker is the culprit, a regular docker clean might be the better option to mitigate the problem?

Out of interest:

  • Would the docker build also work outside the AGW VM?

@crasu
Copy link
Contributor Author

crasu commented Aug 26, 2022

  • Is the disk-size for the VMs dynamically allocated?
    yes
  • Depending on the above, this might also be an anti-feature if you are developing on a system with limited hard disk space.
    The disk will only get large if you use the space inside the vm. So this should not be an issue on ci and similar.
  • If docker is the culprit, a regular docker clean might be the better option to mitigate the problem?
    Currently you have to clean the entire docker cache after every build and even that is not enough. There is only 1-2 GB space left after building the agw.

Out of interest:

  • Would the docker build also work outside the AGW VM?
    At the moment we have no way to quickly transfer the containers inside the VM. This would also require to setup parts of the dev tool chain locally which kind of defeats the purpose of the dev vm.

@crasu crasu force-pushed the pr/increase-agw-disk-size-for-containers branch from aef6f56 to 817c357 Compare August 26, 2022 12:04
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

agw-workflow

615 tests   611 ✔️  4m 26s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 66005e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

dp-workflow

14 tests   14 ✔️  3m 9s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 66005e9.

♻️ This comment has been updated with latest results.

@@ -131,7 +131,7 @@ jobs:
run: |
pip3 install --upgrade pip
pip3 install ansible fabric3 jsonpickle requests PyYAML
vagrant plugin install vagrant-vbguest vagrant-vbguest vagrant-mutate
vagrant plugin install vagrant-vbguest vagrant-disksize vagrant-vbguest vagrant-mutate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two times the same parameter ... vagrant-vbguest ... vagrant-vbguest ... ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@crasu crasu force-pushed the pr/increase-agw-disk-size-for-containers branch from 817c357 to aa715c2 Compare August 30, 2022 07:17
@crasu crasu requested a review from ajahl August 30, 2022 07:17
@crasu
Copy link
Contributor Author

crasu commented Aug 30, 2022

Currently the integ tests fails for this PR. Put it to WIP.

@crasu crasu changed the title chore(agw): Increase disk size for agw vm WIP: chore(agw): Increase disk size for agw vm Aug 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2022

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

@crasu
Copy link
Contributor Author

crasu commented Aug 30, 2022

Currently the integ tests fails for this PR. Put it to WIP.

Failures seem to be unrelated to these changes

@crasu crasu force-pushed the pr/increase-agw-disk-size-for-containers branch from aa715c2 to b790882 Compare August 30, 2022 15:44
@crasu crasu changed the title WIP: chore(agw): Increase disk size for agw vm chore(agw): Increase disk size for agw vm Aug 30, 2022
…tainerized agw

Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
@crasu crasu force-pushed the pr/increase-agw-disk-size-for-containers branch from b790882 to 66005e9 Compare August 30, 2022 15:47
Copy link
Contributor

@voisey voisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs changes look good

@crasu crasu merged commit c361224 into magma:master Sep 5, 2022
mpfirrmann pushed a commit to wolfseb/magma that referenced this pull request Sep 5, 2022
…tainerized agw (magma#13750)

Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants