-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(agw): Increase disk size for agw vm #13750
chore(agw): Increase disk size for agw vm #13750
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
f029a29
to
aef6f56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is the disk-size for the VMs dynamically allocated?
- Depending on the above, this might also be an anti-feature if you are developing on a system with limited hard disk space.
- If docker is the culprit, a regular docker clean might be the better option to mitigate the problem?
Out of interest:
- Would the docker build also work outside the AGW VM?
|
aef6f56
to
817c357
Compare
.github/workflows/build_all.yml
Outdated
@@ -131,7 +131,7 @@ jobs: | |||
run: | | |||
pip3 install --upgrade pip | |||
pip3 install ansible fabric3 jsonpickle requests PyYAML | |||
vagrant plugin install vagrant-vbguest vagrant-vbguest vagrant-mutate | |||
vagrant plugin install vagrant-vbguest vagrant-disksize vagrant-vbguest vagrant-mutate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two times the same parameter ... vagrant-vbguest ... vagrant-vbguest ...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
817c357
to
aa715c2
Compare
Currently the integ tests fails for this PR. Put it to WIP. |
✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles. |
Failures seem to be unrelated to these changes |
aa715c2
to
b790882
Compare
…tainerized agw Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
b790882
to
66005e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs changes look good
…tainerized agw (magma#13750) Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
Summary
Disk size for agw containers was increased to 75GB to accomdate build of dockerized agw containers. Vagrant cannot
handle file system resizing for the container - probably because it uses lvm.
Test Plan
Tested increased container size locally. You need to remove all your vms from virtualbox (including the base vm virtualboxes uses for quicker vm setup) to test this.
AGW integ run: https://github.com/crasu/magma/actions/workflows/lte-integ-test.yml