fix(agw): c++ migration of nas/emm/msg files #13754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
pull-request-size
bot
added
the
size/XXL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
rsarwad
reviewed
Aug 26, 2022
LKreutzer
requested changes
Aug 26, 2022
rsarwad
reviewed
Aug 29, 2022
lte/gateway/c/core/oai/test/mme_app_task/test_mme_app_emm_encode_decode.cpp
Show resolved
Hide resolved
rsarwad
reviewed
Aug 29, 2022
lte/gateway/c/core/oai/test/mme_app_task/test_mme_app_nas_encode_decode.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
rsarwad
reviewed
Aug 29, 2022
| @@ -50,12 +50,17 @@ typedef struct authentication_response_msg_tag { | |||
| authentication_response_parameter_t authenticationresponseparameter; | |||
| } authentication_response_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| #endif | |||
There was a problem hiding this comment.
Here also we don't need extern for same reason
| @@ -78,12 +78,18 @@ typedef struct cs_service_notification_msg_tag { | |||
| LcsClientIdentity lcsclientidentity; | |||
| } cs_service_notification_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| #endif | |||
| @@ -74,10 +74,16 @@ typedef struct emm_information_msg_tag { | |||
| daylight_saving_time_t networkdaylightsavingtime; | |||
| } emm_information_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| @@ -65,12 +65,17 @@ typedef struct extended_service_request_msg_tag { | |||
| csfb_response_t csfbresponse; | |||
| } extended_service_request_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| @@ -83,10 +83,15 @@ typedef struct security_mode_command_msg_tag { | |||
| nonce_t noncemme; | |||
| } security_mode_command_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| @@ -56,12 +56,18 @@ typedef struct security_mode_complete_msg_tag { | |||
| mobile_identity_t imeisv; | |||
| } security_mode_complete_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| @@ -47,12 +47,18 @@ typedef struct tracking_area_update_reject_msg_tag { | |||
| emm_cause_t emmcause; | |||
| } tracking_area_update_reject_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| @@ -175,12 +175,17 @@ typedef struct tracking_area_update_request_msg_tag { | |||
| ue_additional_security_capability_t ueadditionalsecuritycapability; | |||
| } tracking_area_update_request_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| @@ -49,10 +49,15 @@ typedef struct uplink_nas_transport_msg_tag { | |||
| NasMessageContainer nasmessagecontainer; | |||
| } uplink_nas_transport_msg; | |||
|
|
|||
| #ifdef __cplusplus | |||
| extern "C" { | |||
| #endif | |||
Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
rsarwad
pushed a commit
to rsarwad/magma
that referenced
this pull request
Sep 4, 2022
* Renamed files * Resolved compilation errors Signed-off-by: Pruthvi Hebbani <pruthvi.hebbani@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(agw): c++ migration of nas/emm/msg files
Summary
Migrated all the files under nas/emm/msg to cpp/hpp and fixed all the compilation errors and warnings
Test Plan
Executed s1ap integ_tests and unit test