Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Build and set up the scripts needed to run services in the bazel LTE integ test workflow #13803

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix(ci): Build and set up the scripts needed to run services in the bazel LTE integ test workflow #13803

merged 1 commit into from
Sep 2, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Sep 1, 2022 •
edited

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • Fix the broken Bazel LTE integ test workflow by building and setting up the needed scripts used in service definitions.
  • In the PR chore(ci): Run the sudo tests with bazel #13772 a Make call was removed that also set up a python env.
    • With bazel this is not needed, but the scripts have to be build with bazel instead.

Test Plan

  • Running selected LTE integ tests locally.
  • LTE integ tests
    • Some individual test failures, but overall the issue was fixed (i.e. the services are running.)
      • test_ipv6_paging_with_dedicated_bearer
      • test_ipv4v6_paging_with_dedicated_bearer
      • These are failing locally as well.

Additional Information

@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) LTE-Integration-Test Issues relating to LTE Integration Tests bazel changes for the Bazelification effort labels Sep 1, 2022
@LKreutzer LKreutzer self-assigned this Sep 1, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022 •
edited

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5c7f643.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer force-pushed the fix_bazel_integ_tests branch 2 times, most recently from 82c8674 to 157a2e6 Compare September 1, 2022 12:12
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Sep 1, 2022
@LKreutzer LKreutzer force-pushed the fix_bazel_integ_tests branch 2 times, most recently from 5f34152 to c817b64 Compare September 1, 2022 14:48
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 1, 2022
@LKreutzer LKreutzer requested a review from nstng September 1, 2022 15:19
@LKreutzer LKreutzer marked this pull request as ready for review September 1, 2022 15:19
@LKreutzer LKreutzer requested a review from a team September 1, 2022 15:19
@LKreutzer LKreutzer requested a review from a team as a code owner September 1, 2022 15:19
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022 •
edited

agw-workflow

615 tests   611 ✔️  4m 57s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 5c7f643.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer mentioned this pull request Sep 2, 2022
Closed
1 task
nstng
nstng approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comments

bazel/scripts/link_scripts_for_bazel_integ_tests.sh Outdated Show resolved Hide resolved
bazel/scripts/link_scripts_for_bazel_integ_tests.sh Show resolved Hide resolved
@LKreutzer
fix(ci): Set up the scripts needed in the bazel LTE integ test workflow
5c7f643 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com
@LKreutzer LKreutzer enabled auto-merge (squash) September 2, 2022 12:32
@LKreutzer LKreutzer merged commit d7e2482 into magma:master Sep 2, 2022
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
@LKreutzer @rsarwad
fix(ci): Set up the scripts needed in the bazel LTE integ test workfl…
32f2767 
…ow (magma#13803)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstng nstng nstng approved these changes

Assignees

@LKreutzer LKreutzer

@nstng nstng

@vktng vktng

Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) LTE-Integration-Test Issues relating to LTE Integration Tests size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LKreutzer @nstng @crasu @vktng