Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Trigger all bazel workflow jobs by pushing to master #13825

Merged
merged 1 commit into from
Sep 2, 2022
Merged

fix(ci): Trigger all bazel workflow jobs by pushing to master #13825

merged 1 commit into from
Sep 2, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Sep 2, 2022 •
edited

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • The bazel workflow is currently triggered on master by pushes but the individual jobs still have references to github.event_name == 'schedule', these are replaced by github.event_name == 'push'
  • Some minor other clean up of the if conditions

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer
fix(ci): Trigger all bazel workflow jobs by pushing to master
7142f65 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Sep 2, 2022
@LKreutzer LKreutzer self-assigned this Sep 2, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 7142f65.

@LKreutzer LKreutzer requested a review from nstng September 2, 2022 14:08
@LKreutzer LKreutzer marked this pull request as ready for review September 2, 2022 14:08
@LKreutzer LKreutzer requested a review from a team September 2, 2022 14:08
nstng
nstng approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for finding and fixing this

@LKreutzer LKreutzer merged commit 13f8b02 into magma:master Sep 2, 2022
rsarwad pushed a commit to rsarwad/magma that referenced this pull request Sep 4, 2022
@LKreutzer @rsarwad
fix(ci): Trigger all bazel workflow jobs by pushing to master (magma#…
3805d00 
…13825)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstng nstng nstng approved these changes

Assignees

@LKreutzer LKreutzer

Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LKreutzer @nstng