Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Fix for the issue related to earlier kernels as reported in #13831 #13834

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jordanvrtanoski
Copy link
Contributor

@jordanvrtanoski jordanvrtanoski commented Sep 4, 2022

Summary

Introduced conditional code block in the source of vport_gtp as a patch to OVS to fix issue reported with #13831. The code block contains implementation of the IPv6 flow lookup that is compliant to earlier kernels. The conditional block is activated only in case of kernels prior 5.4.5 and 5.3.18

Test Plan

Standard OVS integration tests ware executed.

## ------------------------------ ##
## openvswitch 2.15.4 test suite. ##
## ------------------------------ ##

layer3-tunnels

144: layer3 - ping over GTP                          ok
145: layer3 - IPv6 packets over IPv6 GTP             ok
146: layer3 - IPv6 packets over IPv4 GTP             ok
147: layer3 - IPv4 packets over IPv6 GTP             ok
148: layer3 - GTP echo match test                    ok
149: layer3 - IPv6 GTP echo match test               ok
150: layer3 - GTP echo response test                 ok
151: layer3 - IPv6 GTP echo response test            ok
152: layer3 - GTP echo response test multi endpoint  ok
153: layer3 - IPv6 GTP echo response test multi endpoint ok
154: layer3 - GTP end marker test                    ok
155: layer3 - IPv6 GTP end marker test               ok
156: layer3 - Qfi value set for uplink over GTP      ok
157: layer3 - Qfi value set for downlink over GTP    ok

## ------------- ##
## Test results. ##
## ------------- ##

All 14 tests were successful.

The patch was verified on devices with earlier kernel by using srsRAN

Additional Information

Closes #13831

Introducing new conditional code that will be activated when compiled on
earlier kernels.
The conditional code will use the older version of the API
`ipv6_stub->ipv6_dst_lookup` instead of the newer one
`ipv6_stub->ipv6_dst_lookup_flow`. The code will not be active on
kernels that have implementation of `ipv6_stub->ipv6_dst_lookup_flow()`

Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit f1e9850.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

❌ The Semantic PR check ended with status failure. See instructions on formatting your commit and pull request titles.

@jordanvrtanoski jordanvrtanoski changed the title fix(ovs): Fix for the issue related to earlier kernels as reported in 13831 fix(ovs): Fix for the issue related to earlier kernels as reported in #13831 Sep 4, 2022
@m-govind
Copy link
Contributor

m-govind commented Sep 4, 2022

Looks good to me.

Copy link
Contributor

@m-govind m-govind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@maxhbr
Copy link
Member

maxhbr commented Nov 8, 2022

Error: Unknown scope "ovs" found in pull request title "fix(ovs): Fix for the issue related to earlier kernels as reported in #13831 ". Use one of the available scopes: aaa_server, agw, amf, ci, cloud, connectiond, control_proxy, csfb, ctraced, cwg, deps, deps-dev, directoryd, dp, eap, eap_aka, eap_sim, enodebd, envoy_controller, eventd, feg, feg_hello, feg_relay, health, lte, magmad, mme, mobilityd, monitord, nms, orc8r, pipelined, policydb, radiusd, redirectd, redis, s6a_proxy, s8_proxy, sctpd, session_proxy, sessiond, smf, smsd, state, subscriberdb, swx_proxy, td-agent-bit, upf.

@jordanvrtanoski , you need to change the scope in the PR title

@MoritzThomasHuebner MoritzThomasHuebner changed the title fix(ovs): Fix for the issue related to earlier kernels as reported in #13831 fix(agw): Fix for the issue related to earlier kernels as reported in #13831 Mar 8, 2023
@MoritzThomasHuebner
Copy link
Contributor

@jordanvrtanoski Is this PR still relevant, or can it be closed? I changed the scope so in theory it could be merged with approval.

@jordanvrtanoski jordanvrtanoski requested a review from a team as a code owner June 26, 2023 04:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 63d1662.

♻️ This comment has been updated with latest results.

@prabinakpattnaik
Copy link
Contributor

Looks OK to me. Please rebase with Master.

@lucasgonze
Copy link
Contributor

The failing tests are trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVS datapath vport_gtp can not be compiled on kernel earlier than 5.4.5 and 5.3.18
7 participants