-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): Fix for the issue related to earlier kernels as reported in #13831 #13834
base: master
Are you sure you want to change the base?
Conversation
Introducing new conditional code that will be activated when compiled on earlier kernels. The conditional code will use the older version of the API `ipv6_stub->ipv6_dst_lookup` instead of the newer one `ipv6_stub->ipv6_dst_lookup_flow`. The code will not be active on kernels that have implementation of `ipv6_stub->ipv6_dst_lookup_flow()` Signed-off-by: Jordan Vrtanoski <jordan.vrtanoski@gmail.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
❌ The Semantic PR check ended with status failure. See instructions on formatting your commit and pull request titles. |
Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@jordanvrtanoski , you need to change the scope in the PR title |
@jordanvrtanoski Is this PR still relevant, or can it be closed? I changed the scope so in theory it could be merged with approval. |
Looks OK to me. Please rebase with Master. |
The failing tests are trivial. |
Summary
Introduced conditional code block in the source of vport_gtp as a patch to OVS to fix issue reported with #13831. The code block contains implementation of the IPv6 flow lookup that is compliant to earlier kernels. The conditional block is activated only in case of kernels prior 5.4.5 and 5.3.18
Test Plan
Standard OVS integration tests ware executed.
The patch was verified on devices with earlier kernel by using srsRAN
Additional Information
Closes #13831