fix(agw): Modified code to replace state_teid_hash list to protobuf map in spgw task #13835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
Oops! Looks like you failed the Howto |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -54,7 +48,7 @@ void delete_pending_procedures( | |||
| base_proc1 = base_proc2; | |||
| } | |||
| LIST_INIT(ctx_p->pending_procedures); | |||
| free_wrapper((void**)&ctx_p->pending_procedures); | |||
| free_cpp_wrapper((void**)&ctx_p->pending_procedures); | |||
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
| delete_pending_procedures( | ||
| &(context_p->sgw_eps_bearer_context_information)); | ||
|
|
||
| free_cpp_wrapper((void**)ptr); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
| @@ -1475,7 +1475,7 @@ void sgw_s8_proc_s11_create_bearer_rsp( | |||
| if (pgw_ni_cbr_proc && (LIST_EMPTY(pgw_ni_cbr_proc->pending_eps_bearers))) { | |||
| pgw_base_proc_t* base_proc1 = LIST_FIRST(sgw_context_p->pending_procedures); | |||
| LIST_REMOVE(base_proc1, entries); | |||
| free_wrapper((void**)&sgw_context_p->pending_procedures); | |||
| free_cpp_wrapper((void**)&sgw_context_p->pending_procedures); | |||
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(agw): Modified code to replace state_teid_hash list to protobuf map in spgw task
Test Plan
Executed s1ap sanity test suite and unit test cases.