-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(feg): Added vagrant-reload to workflows #13849
fix(feg): Added vagrant-reload to workflows #13849
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
0b12b3c
to
77e48d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the other vagrant-plugins?
vagrant-disksize vagrant-mutate
I think they're mostly there already, but I'm not sure that all plugins are used exactly where they're required and only there. However, it seems it was the recent introduction of vagrant-reload that broke master. So I'm merging this to hopefully resolve that issue. |
Signed-off-by: Moritz Huebner moritz.huebner@tngtech.com
Summary
Follow up to #13823.
vagrant-reload
was not installed during the workflow. I just added this in all workflows, but I can figure out the minimal set.Test Plan
Integ tests pass now:
https://github.com/MoritzThomasHuebner/magma/runs/8200180055?check_suite_focus=true
Additional Information