Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feg): Added vagrant-reload to workflows #13849

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

MoritzThomasHuebner
Copy link
Contributor

@MoritzThomasHuebner MoritzThomasHuebner commented Sep 6, 2022

Signed-off-by: Moritz Huebner moritz.huebner@tngtech.com

Summary

Follow up to #13823.

vagrant-reload was not installed during the workflow. I just added this in all workflows, but I can figure out the minimal set.

Test Plan

Integ tests pass now:
https://github.com/MoritzThomasHuebner/magma/runs/8200180055?check_suite_focus=true

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 77e48d1.

♻️ This comment has been updated with latest results.

Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
@pull-request-size pull-request-size bot removed the size/XS Denotes a PR that changes 0-9 lines. label Sep 6, 2022
@MoritzThomasHuebner MoritzThomasHuebner marked this pull request as ready for review September 6, 2022 08:05
@MoritzThomasHuebner MoritzThomasHuebner requested a review from a team as a code owner September 6, 2022 08:05
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 6, 2022
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other vagrant-plugins?
vagrant-disksize vagrant-mutate

@Neudrino Neudrino removed the request for review from maxhbr September 6, 2022 11:13
@sebathomas
Copy link
Contributor

What about the other vagrant-plugins? vagrant-disksize vagrant-mutate

I think they're mostly there already, but I'm not sure that all plugins are used exactly where they're required and only there.

However, it seems it was the recent introduction of vagrant-reload that broke master. So I'm merging this to hopefully resolve that issue.

@sebathomas sebathomas merged commit f0c3169 into magma:master Sep 6, 2022
@MoritzThomasHuebner MoritzThomasHuebner deleted the fix_fed_integ_test branch September 7, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants