chore(agw): s1ap_utils.py is cleaned up #13854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
mpfirrmann
force-pushed
the
pr/cleanup_s1ap_utils
branch
from
9a632b0
to
517f8d6
Compare
10 tasks
mpfirrmann
force-pushed
the
pr/cleanup_s1ap_utils
branch
from
517f8d6
to
50f0475
Compare
pull-request-size
bot
added
size/XL
voisey
reviewed
Sep 13, 2022
mpfirrmann
force-pushed
the
pr/cleanup_s1ap_utils
branch
from
50f0475
to
fd5ace9
Compare
pull-request-size
bot
added
size/L
Default settings. The main motivation for this PR was the reordering of the functions and after that it was more a Boy's Scout thing to clean up. We just wanted to separate these changes from the feature PR. |
|
@mpfirrmann Have you checked the S1AP tests still run after these changes? |
mpfirrmann
changed the title
s1ap_utils is cleaned up
Yes. I edited the PR description |
voisey
approved these changes
Sep 20, 2022
10 tasks
|
@rsarwad, do you maybe have some time to take a look at this PR? |
rsarwad
reviewed
Sep 23, 2022
| num_ul_flows, | ||
| dl_flow_rules=None, | ||
| ipv6_non_nat=False, | ||
| ): |
There was a problem hiding this comment.
At line 626, can we use curly brackets to get the values?
rsarwad
approved these changes
Sep 23, 2022
mpfirrmann
force-pushed
the
pr/cleanup_s1ap_utils
branch
from
fd5ace9
to
4f9a41f
Compare
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
mpfirrmann
force-pushed
the
pr/cleanup_s1ap_utils
branch
from
4f9a41f
to
cc28655
Compare
mpfirrmann
added
the
ready2merge
7 tasks
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
* chore(agw): functions are reordered for better readability * chore(agw): s1ap_utils is cleaned up for readability Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a clean-up PR for the
s1ap_utils.py. After extensive work in #13853, we shuffled some functions around for better visibility and addressed severalpylintremarks.Test Plan
The LTE integration tests were run on my fork with GitHub actions with a
systemd-base AGW; LINK.Tests ran green for the containerized AGW as well.
Additional Information