Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): Tidy up fabfile #13872

Merged
merged 1 commit into from
Sep 13, 2022
Merged

chore(agw): Tidy up fabfile #13872

merged 1 commit into from
Sep 13, 2022

Conversation

voisey
Copy link
Contributor

@voisey voisey commented Sep 8, 2022

Summary

Removes unused code found when looking at the AGW fabfile.

Test Plan

The workflows are failing on master, hence the above runs are not green.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit b7d164c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

dp-workflow

14 tests   14 ✔️  2m 26s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit b7d164c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

agw-workflow

615 tests   611 ✔️  3m 54s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit b7d164c.

♻️ This comment has been updated with latest results.

@voisey voisey requested a review from ajahl September 8, 2022 12:56
@voisey voisey marked this pull request as ready for review September 12, 2022 14:40
@voisey voisey requested a review from a team as a code owner September 12, 2022 14:40
Copy link
Contributor

@mpfirrmann mpfirrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LKreutzer LKreutzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the clean up!

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@voisey voisey enabled auto-merge (squash) September 13, 2022 08:29
@voisey voisey merged commit e8b2d80 into magma:master Sep 13, 2022
@voisey voisey linked an issue Sep 13, 2022 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run integration tests against debian installation in CI
4 participants