-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(agw): Create convenient aliases in magma-dev VM for service commands #13874
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
…mands Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried if this works after the last changes?
Yes, tested in the magma-dev VM, looked at the status output during the commands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary
_start_gateway
function in the fabfile now just starts the services. The build that happened in themake run
is thus removed. This was an unnecessary second build step in LTE integ tests.make status
command was removed in chore(agw): Clean up unnecessary Make commands #13782Test Plan
magma-status
will only return something aftermagma-start
has run)make run
to see that the services are still startingAdditional Information
Aliases that replace the removed Make commands:
magma-start
starts the services via magmadmagma-stop
stops all magma servicesmagma-restart
restarts magma servicesmagma-status
print status of all magma servicesThis change is backwards-breaking