Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): Create convenient aliases in magma-dev VM for service commands #13874

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Sep 8, 2022

Summary

  • Create convenient aliases in magma-dev VM for service commands in order to replace Make commands
    • Create aliases with ansible for magma-dev and magma-deb
    • Remove Make targets for service commands in LTE and FEG
      • Clean up usage by inlineing or replacement with the aliases
  • The _start_gateway function in the fabfile now just starts the services. The build that happened in the make run is thus removed. This was an unnecessary second build step in LTE integ tests.
  • The make status command was removed in chore(agw): Clean up unnecessary Make commands #13782
    • Since it was actually used by people it was re-added here as an alias
  • Resolves Create convenient aliases for systemd commands #13811

Test Plan

Additional Information

Aliases that replace the removed Make commands:

  • magma-start starts the services via magmad

  • magma-stop stops all magma services

  • magma-restart restarts magma services

  • magma-status print status of all magma services

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 8, 2022
@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel-cleanup BE fixups that came out of the Bazelification effort and removed component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue component: feg FEG-gateway related issues labels Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit fb0da8c.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer marked this pull request as ready for review September 8, 2022 13:42
@LKreutzer LKreutzer requested a review from a team September 8, 2022 13:42
@LKreutzer LKreutzer requested a review from a team as a code owner September 8, 2022 13:42
@LKreutzer LKreutzer requested a review from a team September 8, 2022 13:42
@LKreutzer LKreutzer requested a review from a team as a code owner September 8, 2022 13:42
@LKreutzer LKreutzer requested review from Neudrino, ardzoht, emakeev, crasu, sebathomas and nstng and removed request for emakeev, ardzoht and nstng September 8, 2022 13:42
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

dp-workflow

14 tests   14 ✔️  3m 8s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit fb0da8c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

agw-workflow

615 tests   611 ✔️  3m 52s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit fb0da8c.

♻️ This comment has been updated with latest results.

ci-scripts/JenkinsFile-GitLab Outdated Show resolved Hide resolved
ci-scripts/JenkinsFile-GitLab Outdated Show resolved Hide resolved
…mands

Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Krisztián Varga krisztian.varga@tngtech.com

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Copy link
Contributor

@crasu crasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried if this works after the last changes?

@LKreutzer
Copy link
Contributor Author

Have you tried if this works after the last changes?

Yes, tested in the magma-dev VM, looked at the status output during the commands.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LKreutzer LKreutzer merged commit e2cd8f3 into magma:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel-cleanup BE fixups that came out of the Bazelification effort component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: docs Documentation-related issue component: feg FEG-gateway related issues size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create convenient aliases for systemd commands
6 participants