feat(ci): s1ap integ tests against dockerized agw #13884

alexzurbonsen · 2022-09-09T11:24:51Z

Summary

Contributes to CI support for dockerized agw attach dettach test #13695
A new workflow is created, which runs some integration tests against a containerized instance of AGW running on the Magma Dev VM.
- Only attach-detach test for this PR.
This is the first iteration of testing the containerized AGW in CI.
- The workflow was designed based on the exiting workflows.
- It is expected that further optimisation can be made in follow ups later on.
- Some integration test are flaky in general, such that for this stage, one successful run will be seen as solution.
The tests are run against the latest images of the services available.
- Especially, it is out of scope to build the containerized AGW within this effort and PR.
- Using the latest available images should provide sufficient additional information, if there is a sensible trigger to the workflow. In particular, any edge cases or race conditions are acquiesced!

Test Plan

See runs: https://github.com/magma/magma/actions/workflows/lte-integ-test-containerized.yml
- ✔️ Successful at https://github.com/magma/magma/actions/runs/3190270518/jobs/5205143748.

Additional Information

As a guide: https://github.com/magma/magma/blob/master/lte/gateway/docker/README.md#running-the-containerized-agw-locally-on-the-magma-vm

github-actions · 2022-09-09T11:25:06Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-09-09T11:40:58Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 74230cf.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-09T11:59:47Z

dp-workflow

14 tests 14 ✔️ 2m 18s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 74230cf.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-09T12:39:19Z

agw-workflow

615 tests 611 ✔️ 4m 47s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit b28ab3d.

♻️ This comment has been updated with latest results.

lte/gateway/docker/docker-compose.yaml

lte/gateway/fabfile.py

.github/workflows/lte-integ-test-containerized.yml

… agw running on magma_dev VM Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>

.github/workflows/lte-integ-test-containerized.yml

lte/gateway/fabfile.py

.github/workflows/lte-integ-test-containerized.yml

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

.github/workflows/lte-integ-test-containerized.yml

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

voisey

Lgtm but please wait for @sebathomas to approve before merging.

* chore(ci): add workflow that runs s1ap integ tests against dockerized agw running on magma_dev VM Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com> * chore(ci): correct spelling of set up Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * chore(ci): shorten and clarify docstring Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * chore(ci): improve whitespace consistency Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> * chore(ci): remove debug output Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com> Co-authored-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Sep 9, 2022

github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Sep 9, 2022

alexzurbonsen force-pushed the ci-dockerized-agw-s1ap-tests branch from c3f27a5 to 70d1dc2 Compare September 9, 2022 11:27

alexzurbonsen force-pushed the ci-dockerized-agw-s1ap-tests branch from 70d1dc2 to 3d4c6f3 Compare September 9, 2022 15:55

Neudrino self-assigned this Sep 12, 2022

Neudrino force-pushed the ci-dockerized-agw-s1ap-tests branch 7 times, most recently from 4cfde66 to 9ccbfd3 Compare September 13, 2022 12:56

alexzurbonsen mentioned this pull request Sep 14, 2022

[WIP] chore(ci): s1ap integ tests against containerized agw #13928

Closed

1 task

Neudrino force-pushed the ci-dockerized-agw-s1ap-tests branch 4 times, most recently from b7d66ae to d3820af Compare September 15, 2022 13:18

magma deleted a comment from github-actions bot Sep 15, 2022

github-actions bot reviewed Sep 15, 2022

View reviewed changes

lte/gateway/docker/docker-compose.yaml Outdated Show resolved Hide resolved

Neudrino force-pushed the ci-dockerized-agw-s1ap-tests branch from d3820af to abcd0fc Compare September 15, 2022 16:53

MoritzThomasHuebner reviewed Sep 16, 2022

View reviewed changes

lte/gateway/fabfile.py Outdated Show resolved Hide resolved

Neudrino force-pushed the ci-dockerized-agw-s1ap-tests branch 2 times, most recently from 9eafef0 to b251582 Compare September 20, 2022 07:58

Neudrino requested review from voisey and ajahl and removed request for ssanadhya October 5, 2022 15:09

jheidbrink reviewed Oct 5, 2022

View reviewed changes

.github/workflows/lte-integ-test-containerized.yml Outdated Show resolved Hide resolved

jheidbrink approved these changes Oct 5, 2022

View reviewed changes

Neudrino mentioned this pull request Oct 5, 2022

feat(ci): better startup test for the integration test against containerized AGW #14090

Merged

chore(ci): add workflow that runs s1ap integ tests against dockerized…

c8daa0b

… agw running on magma_dev VM Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com> Signed-off-by: Alexander zur Bonsen <alexander.zur.bonsen@tngtech.com>

Neudrino force-pushed the ci-dockerized-agw-s1ap-tests branch from ad03813 to c8daa0b Compare October 6, 2022 08:52

Neudrino enabled auto-merge (squash) October 6, 2022 08:53

sebathomas reviewed Oct 6, 2022

View reviewed changes

.github/workflows/lte-integ-test-containerized.yml Show resolved Hide resolved

.github/workflows/lte-integ-test-containerized.yml Show resolved Hide resolved

voisey reviewed Oct 6, 2022

View reviewed changes

voisey mentioned this pull request Oct 6, 2022

chore(ci): add workflow that runs s1ap integ tests against dockerized… #14023

Closed

voisey linked an issue Oct 6, 2022 that may be closed by this pull request

CI support for dockerized agw attach dettach test #13695

Closed

chore(ci): correct spelling of set up

845319c

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

Neudrino mentioned this pull request Oct 6, 2022

Fix snowflake issue in LTE integration test #13912

Closed

2 tasks

Neudrino added 2 commits October 6, 2022 12:32

chore(ci): shorten and clarify docstring

b6121b3

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

chore(ci): improve whitespace consistency

b28ab3d

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

Neudrino requested review from voisey, sebathomas and MoritzThomasHuebner October 6, 2022 10:34

voisey reviewed Oct 6, 2022

View reviewed changes

.github/workflows/lte-integ-test-containerized.yml Outdated Show resolved Hide resolved

chore(ci): remove debug output

74230cf

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

Neudrino requested a review from voisey October 6, 2022 12:09

voisey approved these changes Oct 6, 2022

View reviewed changes

voisey disabled auto-merge October 6, 2022 12:11

sebathomas approved these changes Oct 6, 2022

View reviewed changes

voisey merged commit 849f777 into magma:master Oct 6, 2022

Neudrino changed the title ~~chore(ci): s1ap integ tests against dockerized agw~~ feat(ci): s1ap integ tests against dockerized agw Oct 10, 2022

jheidbrink mentioned this pull request Nov 22, 2022

Remove docker-ci registry #14505

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ci): s1ap integ tests against dockerized agw #13884

feat(ci): s1ap integ tests against dockerized agw #13884

alexzurbonsen commented Sep 9, 2022 •

edited by Neudrino

github-actions bot commented Sep 9, 2022

github-actions bot commented Sep 9, 2022 •

edited

github-actions bot commented Sep 9, 2022 •

edited

github-actions bot commented Sep 9, 2022 •

edited

voisey left a comment

feat(ci): s1ap integ tests against dockerized agw #13884

feat(ci): s1ap integ tests against dockerized agw #13884

Conversation

alexzurbonsen commented Sep 9, 2022 • edited by Neudrino

Summary

Test Plan

Additional Information

github-actions bot commented Sep 9, 2022

Howto

More info

github-actions bot commented Sep 9, 2022 • edited

feg-workflow

github-actions bot commented Sep 9, 2022 • edited

dp-workflow

github-actions bot commented Sep 9, 2022 • edited

agw-workflow

voisey left a comment

Choose a reason for hiding this comment

alexzurbonsen commented Sep 9, 2022 •

edited by Neudrino

github-actions bot commented Sep 9, 2022 •

edited

github-actions bot commented Sep 9, 2022 •

edited

github-actions bot commented Sep 9, 2022 •

edited