Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): Show an error message if the user login fails #13888

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

sebathomas
Copy link
Contributor

Summary

Before this change, the user got no feedback if they typed a wrong password.

NMS already recognized invalid logins via a query parameter, and there was an error property in the login form, the two features were just not put together.

Fixes #13429.

Test Plan

Started NMS locally and entered a wrong password.

nmslogin

Additional Information

  • This change is backwards-breaking

@sebathomas sebathomas requested review from a team and HannaFar September 9, 2022 15:06
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: nms NMS-related issue label Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b86fdcc.

♻️ This comment has been updated with latest results.

nms/app/login.tsx Outdated Show resolved Hide resolved
nms/app/login.tsx Outdated Show resolved Hide resolved
nms/app/login.tsx Outdated Show resolved Hide resolved
nms/app/login.tsx Outdated Show resolved Hide resolved
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit b86fdcc.

@Neudrino Neudrino requested review from Neudrino and removed request for HannaFar September 12, 2022 08:31
@sebathomas sebathomas merged commit 3c5edbf into magma:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show errors on login page
2 participants