Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Add repository with grpc-dev version 1.43 #13896

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Sep 12, 2022

Co-authored-by: Jan Heidbrink jan.heidbrink@tngtech.com

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • In the devcontainer there is currently no repository that has the grpc-dev version 1.43.
    • As a temporary workaround we add the focal-1.7.0 repository which has this version.

Test Plan

Additional Information

  • This change is backwards-breaking

Co-authored-by: Jan Heidbrink <jan.heidbrink@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 12, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 9e57354.

@LKreutzer LKreutzer added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 12, 2022
@LKreutzer LKreutzer marked this pull request as ready for review September 12, 2022 14:36
@LKreutzer LKreutzer enabled auto-merge (squash) September 12, 2022 14:58
@LKreutzer LKreutzer merged commit c4de1e5 into magma:master Sep 12, 2022
@jheidbrink
Copy link
Contributor

The long-term solution will be implemented in #13903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants