fix(agw): Fix wildcard expansion error in magma aliases

[LKreutzer]

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Jan Heidbrink jan.heidbrink@tngtech.com
Co-authored-by: Nils Semmelrock nils.semmelrock@tngtech.com
Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

• If bash cannot expand a wildcard it hands the expression literally to the command if it can expand it it hands over the expanded expression
  • This results in an error for the case of magma* e.g. in the home directory where the magma folder exists as service is handed the expanded expression instead of the service.
  • In other directories it is handed magma* which service then expands to the services.
  • This can be fixed by adding quotation marks

Test Plan

• vagrant up magma
• vagrant ssh magma
• cd ~ && magma-start && magma-status

Additional Information

• This change is backwards-breaking

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 29736b3.

[github-actions]

dp-workflow

14 tests   14 ✔️  2m 18s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 29736b3.

[github-actions]

agw-workflow

615 tests   611 ✔️  3m 46s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 29736b3.