chore(agw): cleanup apt installs in agw Dockerfiles #13932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
jheidbrink
reviewed
Sep 15, 2022
| openvswitch-common \ | ||
| openvswitch-datapath-dkms \ | ||
| openvswitch-switch |
There was a problem hiding this comment.
Do we want a && rm -rf /var/lib/apt/lists/* here?
jheidbrink
reviewed
Sep 15, 2022
| libopenvswitch \ | ||
| openvswitch-datapath-dkms \ | ||
| openvswitch-common \ | ||
| openvswitch-switch \ | ||
| bcc-tools \ | ||
| td-agent-bit \ | ||
| wireguard |
There was a problem hiding this comment.
Do we want a && rm -rf /var/lib/apt/lists/* here?
|
nitpick: personally I prefer meaningful |
jheidbrink
approved these changes
Sep 15, 2022
jheidbrink
reviewed
Sep 15, 2022
| prometheus-cpp-dev \ | ||
| liblfds710 | ||
| RUN rm /etc/apt/sources.list.d/magma.list | ||
| && rm /etc/apt/sources.list.d/magma.list |
There was a problem hiding this comment.
as discussed offlne: The RUN statement will remain untouched, and the rm will target /var/lib/apt/lists/* instead.
wolfseb
force-pushed
the
cleanup_apt_installs_in_agw_dockerfiles
branch
2 times, most recently
from
0578127
to
753d705
Compare
Sort all installed packages alphabetically, remove duplicates, and add explicit cleanup after installing Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
cleanup_apt_installs_in_agw_dockerfiles
branch
from
753d705
to
a1367cd
Compare
Neudrino
approved these changes
Sep 15, 2022
ShubhamTatvamasi
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com
Summary
This PR sorts all installed packages alphanumerically for better maintainability. Duplicate packages are removed. An explicit cleanup is introduced after every install, where it was not done yet.
Test Plan
Additional Information