Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Mitigate LSAN errors in LTE integ tests #13940

Merged
merged 1 commit into from
Sep 22, 2022
Merged

fix(ci): Mitigate LSAN errors in LTE integ tests #13940

merged 1 commit into from
Sep 22, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Sep 15, 2022 •
edited by nstng

Co-authored-by: Lars Kreutzer lars.kreutzer@tngtech.com
Co-authored-by: Nils Semmelrock nils.semmelrock@tngtech.com
Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

  • There are frequent memory leaks when MME is restarting.
    • The leaks likely originate in the context of intertask_interface.c:214 and shared_ts_log.c:185
    • The leaks finally occur in the following libraries:
      • libczmq.so.4
      • libzmq.so.5
      • fluid_base::BaseOFConnection::OFReadBuffer::read_notify
  • As a temporary mitigation we suppress the leaks that occur in these locations.
  • See also mme leaks on CI environments are mitigated #13941
  • To reproduce the leak start the setup for the extended LTE integ tests and watch the /var/log/syslog on the magma_dev VM for ERROR: LeakSanitizer
  • Additionally the logging for leaks is improved by using the ASAN option fast_unwind_on_malloc=0 (produces a more detailed stack trace for leaks)
    Closes mme leaks on CI environments are mitigated #13941

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) LTE-Integration-Test Issues relating to LTE Integration Tests labels Sep 15, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 15, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue and removed component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Sep 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022 •
edited

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 233d613.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 47s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 233d613.

♻️ This comment has been updated with latest results.

@nstng nstng mentioned this pull request Sep 15, 2022
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2022 •
edited

agw-workflow

615 tests   611 ✔️  4m 25s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 233d613.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022 •
edited

Oops! Looks like you failed the DCO check. Be sure to sign all your commits.

Howto

♻️ Updated: ✅ The check is passing the DCO check after the last commit.

@nstng nstng force-pushed the mitigate_lsan_errors branch 2 times, most recently from d9f692f to 65becd1 Compare September 18, 2022 16:33
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Sep 18, 2022
@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 18, 2022
@thinhnt1983 thinhnt1983 mentioned this pull request Sep 19, 2022
Open
18 tasks
@LKreutzer @nstng
fix(ci): Mitigate LSAN errors in LTE integ tests
233d613 
Co-authored-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Co-authored-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Sep 19, 2022
@nstng nstng marked this pull request as ready for review September 19, 2022 15:07
@nstng nstng requested a review from a team as a code owner September 19, 2022 15:07
@nstng nstng requested a review from ardzoht September 19, 2022 15:07
@github-actions github-actions bot removed the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 19, 2022
@nstng nstng merged commit c1c2778 into magma:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sebathomas sebathomas sebathomas approved these changes

@ardzoht ardzoht Awaiting requested review from ardzoht ardzoht was automatically assigned from magma/approvers-agw

Assignees

@LKreutzer LKreutzer

@nstng nstng

Labels
component: agw Access gateway-related issue LTE-Integration-Test Issues relating to LTE Integration Tests size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mme leaks on CI environments are mitigated
3 participants
@LKreutzer @sebathomas @nstng