Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): Modified code to remove unused files, pgw_pcef_emulation.cpp/hpp and also removed unused structure, deactivated_predefined_pcc_rules #13943

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

rsarwad
Copy link
Contributor

@rsarwad rsarwad commented Sep 16, 2022

Signed-off-by: Rashmi rashmi.sarwad@radisys.com

Summary

Modified code to remove unused files, pgw_pcef_emulation.cpp hpp and unused structure, deactivated_predefined_pcc_rules at spgw task

Test Plan

Executed s1ap sanity test suite and unit test cases. Also build OAI build using below command:
export FEATURES=mme_oai; make build_oai

…p/hpp and also removed unused structure, deactivated_predefined_pcc_rules

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
@rsarwad rsarwad requested review from a team, nstng and pruthvihebbani September 16, 2022 08:18
@pull-request-size pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label Sep 16, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 0e15e97.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

dp-workflow

14 tests   14 ✔️  2m 14s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 0e15e97.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2022

agw-workflow

615 tests   611 ✔️  4m 55s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 0e15e97.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel changes LGTM

Copy link
Collaborator

@ssanadhya ssanadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

…c_rule

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
@pruthvihebbani pruthvihebbani merged commit 3ab0f9d into magma:master Sep 20, 2022
mpfirrmann pushed a commit to wolfseb/magma that referenced this pull request Sep 21, 2022
…p/hpp and also removed unused structure, deactivated_predefined_pcc_rules (magma#13943)

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XL Denotes a Pull Request that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants