Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: headlines in src/go/README.md are displayed correctly #13972

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

mpfirrmann
Copy link
Contributor

Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com

Summary

The headlines are now displayed correctly in the README.md.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann mpfirrmann requested review from a team and uri200 September 20, 2022 13:53
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@mpfirrmann mpfirrmann removed the request for review from uri200 September 20, 2022 13:58
@mpfirrmann mpfirrmann force-pushed the pr/headlines_src_go_capture_readme branch 3 times, most recently from 8e2d57f to 1426962 Compare September 20, 2022 14:03
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann force-pushed the pr/headlines_src_go_capture_readme branch from 1426962 to f4e62d1 Compare September 20, 2022 14:24
@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 29s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit f4e62d1.

@mpfirrmann mpfirrmann self-assigned this Sep 20, 2022
@mpfirrmann mpfirrmann added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Sep 20, 2022
@voisey voisey merged commit b27f5a8 into magma:master Sep 20, 2022
@mpfirrmann mpfirrmann deleted the pr/headlines_src_go_capture_readme branch September 21, 2022 15:38
mpfirrmann added a commit to wolfseb/magma that referenced this pull request Sep 21, 2022
)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready2merge This PR is ready to be merged (is approved and passes all required checks) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants