Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Publish environment logging for the Bazel integration tests #13977

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

vktng
Copy link
Contributor

@vktng vktng commented Sep 21, 2022

Summary

The logs of the environment (e.g.: syslog) are not published in the Bazel LTE integ tests workflow. This PR fixes this.

Test Plan

CI.

Additional Information

  • This change is backwards-breaking

@vktng vktng added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Sep 21, 2022
@vktng vktng self-assigned this Sep 21, 2022
@vktng vktng requested review from a team as code owners September 21, 2022 09:39
@vktng vktng requested a review from pshelar September 21, 2022 09:39
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 21, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

lte/gateway/fabfile.py Outdated Show resolved Hide resolved
@vktng vktng force-pushed the publish_logging_bazel_integ_tests branch from 1eeaf0e to 231f2e6 Compare September 21, 2022 09:45
@github-actions github-actions bot removed the component: agw Access gateway-related issue label Sep 21, 2022
@vktng vktng changed the title Publish environment logging for the Bazel integration tests chore: Publish environment logging for the Bazel integration tests Sep 21, 2022
@sebathomas
Copy link
Contributor

Strange, the CI isn't running at all.

@nstng
Copy link
Contributor

nstng commented Sep 21, 2022

Strange, the CI isn't running at all.

I can only restart the semantic PR check. @vktng please do a rebase - lets see if this restarts the workflows.

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
@vktng vktng force-pushed the publish_logging_bazel_integ_tests branch from 231f2e6 to daef520 Compare September 21, 2022 13:04
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit daef520.

@vktng
Copy link
Contributor Author

vktng commented Sep 21, 2022

Strange, the CI isn't running at all.

I can only restart the semantic PR check. @vktng please do a rebase - lets see if this restarts the workflows.

Works after rebase.

@nstng nstng merged commit baf3bc7 into magma:master Sep 21, 2022
mpfirrmann pushed a commit to wolfseb/magma that referenced this pull request Sep 21, 2022
…agma#13977)

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>

Signed-off-by: Krisztián Varga <krisztian.varga@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants