Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lte integ tests always publish logs #13991

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Sep 22, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

Currently lte integ test logs (syslog from magma dev, etc) are only published if the run failed. For debugging tests it would be helpful to also have these logs for successful runs - for comparison, seeing undetected issues, ...

Test Plan

  • see that workflow file is not damaged

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng requested a review from a team as a code owner September 22, 2022 15:48
@nstng nstng requested a review from mattymo September 22, 2022 15:48
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 22, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 22, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 0f40050.

@nstng nstng mentioned this pull request Sep 22, 2022
8 tasks
@nstng nstng merged commit 490c962 into magma:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants