Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(agw): restart of sctpd is adapted #14000

Merged
merged 2 commits into from
Sep 27, 2022
Merged

chore(agw): restart of sctpd is adapted #14000

merged 2 commits into from
Sep 27, 2022

Conversation

mpfirrmann
Copy link
Contributor

Summary

Two small chores concerning the restart of sctpd:

  1. Instead of restarting the sctpd before restarting all services (which also includes sctpd) the service is just stopped together with magma@*. This only concerns the systemd case.
  2. All restart_sctpd() calls are redirected to restart_services() with its default 30s waiting time.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann mpfirrmann requested review from a team and pruthvihebbani September 23, 2022 09:09
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 23, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

Oops! Looks like you failed the Python Format Check.

Howto

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 63d497f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 14s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 63d497f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

agw-workflow

615 tests   611 ✔️  5m 16s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 63d497f.

♻️ This comment has been updated with latest results.

@mpfirrmann mpfirrmann self-assigned this Sep 23, 2022
VinashakAnkitAman
VinashakAnkitAman requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same change for missing testcase: s1aptests/test_continuous_random_attach.py

@mpfirrmann
feat(agw): sctpd is stopped before a start via magmad service
cfee8b8 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
VinashakAnkitAman
VinashakAnkitAman requested changes Sep 26, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python format check is failing. Please fix the same.

@mpfirrmann
feat(agw): sctpd is restarted only via restart_services()
63d497f 
Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
VinashakAnkitAman
VinashakAnkitAman approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinashakAnkitAman VinashakAnkitAman merged commit 0b29b74 into magma:master Sep 27, 2022
@mpfirrmann mpfirrmann added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Sep 27, 2022
@mpfirrmann mpfirrmann deleted the pr/adapt_sctpd_restart branch September 27, 2022 16:50
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
@mpfirrmann @pruthvihebbani
chore(agw): restart of sctpd is adapted (magma#14000)
6c0b0ce 
* feat(agw): sctpd is stopped before a start via magmad service

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

* feat(agw): sctpd is restarted only via restart_services()

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@voisey voisey mentioned this pull request Nov 23, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinashakAnkitAman VinashakAnkitAman VinashakAnkitAman approved these changes

@pruthvihebbani pruthvihebbani Awaiting requested review from pruthvihebbani

Assignees

@mpfirrmann mpfirrmann

Labels
component: agw Access gateway-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpfirrmann @VinashakAnkitAman