Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(agw): Remove unused code from pydep #14003

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

sebathomas
Copy link
Contributor

@sebathomas sebathomas commented Sep 23, 2022

Summary

Remove usages of the tarfile module from pydep. This code is not used any more since #2373.

Motivation: Recent reports about security issues, e.g. here.

Test Plan

CI

Additional Information

  • This change is backwards-breaking

Remove usages of the tarfile module from pydep. This code is not
used any more.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
@sebathomas sebathomas requested a review from a team as a code owner September 23, 2022 11:28
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Sep 23, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 23, 2022
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 6bdc33a.

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 14s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 6bdc33a.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  4m 20s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 6bdc33a.

@sebathomas sebathomas merged commit 44cae07 into magma:master Sep 23, 2022
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
Remove usages of the tarfile module from pydep. This code is not
used any more.

Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants