chore: the init system check is less chatty #14004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
8 tasks
nstng
force-pushed
the
omit_not_installed_msg_in_integtests
branch
from
dceecb7
to
2902615
Compare
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
nstng
force-pushed
the
omit_not_installed_msg_in_integtests
branch
from
2902615
to
92d6201
Compare
voisey
approved these changes
Sep 27, 2022
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
If integ tests are executed on a system without docker there is for each test a message
bash: docker: command not found. This PR removes the message.Test Plan
execute an integration test locally and see that it is not failing and that the message is not displayed.
Additional Information