-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agw): Modified code port hash list, temporary_create_session_procedure_id to protobuf map #14005
Conversation
…edure_id to protobuf map Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
} | ||
free_wrapper((void**)sgw_eps_context); | ||
free_wrapper((void**)ptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
} | ||
} | ||
state_cache_p->temporary_create_session_procedure_id_map.map = nullptr; | ||
free_cpp_wrapper((void**)&state_cache_p); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
6ea0b52
to
15f3552
Compare
@@ -170,15 +170,15 @@ struct proto_map_s { | |||
** the map. If key does not exists returns error ** | |||
** ** | |||
***************************************************************************/ | |||
proto_map_rc_t remove(const keyT key) { | |||
proto_map_rc_t remove(const keyT key, bool free_an_entry = true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the second parameter in the description?
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
15f3552
to
11c5b15
Compare
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
3c44da6
to
124e507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with minor comments
** the map. If key does not exists returns error ** | ||
** Description: Takes key parameter.Looks up the corresponding entry from ** | ||
** the map. ** | ||
** By default the argument, free_an_entry is set to true. ** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
** By default the argument, free_an_entry is set to true. ** | |
** By default, the argument free_an_entry is set to true. ** |
// Map- Key: csr_proc_id of uint32_t , Data: | ||
// sgw_eps_bearer_context_information_s* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Map- Key: csr_proc_id of uint32_t , Data: | |
// sgw_eps_bearer_context_information_s* | |
// Map with Key: csr_proc_id of uint32_t | |
// Data: sgw_eps_bearer_context_information_s* |
if (!(state_cache_p->temporary_create_session_procedure_id_map.map)) { | ||
OAILOG_CRITICAL( | ||
LOG_SGW_S8, | ||
"Failed to create temporary_create_session_procedure_id_htbl for " | ||
"Failed to create temporary_create_session_procedure_id_map for " | ||
"SGW_S8 task \n"); | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this check since 'new' would raise the bad_alloc exception if memory allocation fails, terminating the process.
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…edure_id to protobuf map (magma#14005)
Summary
fix(agw): Modified sgw_s8 code to port hash list, temporary_create_session_procedure_id to protobuf map
Test Plan
Executed only unit test suite. For in-bound roaming, End2End scenarios used to be tested in Tera VM setup. Since we are not using the Tera VM setup. We couldn't validate End2End scenario.
Additional Information
Once federated integ_test supports mocked external PGW, we can validate the End2End scenarios for inbound roaming UE