fix(agw): Modified code port hash list, temporary_create_session_procedure_id to protobuf map #14005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edure_id to protobuf map Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| free_wrapper((void**)sgw_eps_context); | ||
| free_wrapper((void**)ptr); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
| } | ||
| } | ||
| state_cache_p->temporary_create_session_procedure_id_map.map = nullptr; | ||
| free_cpp_wrapper((void**)&state_cache_p); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
rsarwad
force-pushed
the
11190_s8_port_csr
branch
from
6ea0b52
to
15f3552
Compare
ajahl
reviewed
Sep 26, 2022
| @@ -170,15 +170,15 @@ struct proto_map_s { | |||
| ** the map. If key does not exists returns error ** | |||
| ** ** | |||
| ***************************************************************************/ | |||
| proto_map_rc_t remove(const keyT key) { | |||
| proto_map_rc_t remove(const keyT key, bool free_an_entry = true) { | |||
There was a problem hiding this comment.
Can you add the second parameter in the description?
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
11190_s8_port_csr
branch
from
15f3552
to
11c5b15
Compare
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
11190_s8_port_csr
branch
from
3c44da6
to
124e507
Compare
ssanadhya
approved these changes
Nov 9, 2022
| ** the map. If key does not exists returns error ** | ||
| ** Description: Takes key parameter.Looks up the corresponding entry from ** | ||
| ** the map. ** | ||
| ** By default the argument, free_an_entry is set to true. ** |
There was a problem hiding this comment.
Suggested change
| ** By default the argument, free_an_entry is set to true. ** | |
| ** By default, the argument free_an_entry is set to true. ** |
Comment on lines
104
to
105
| // Map- Key: csr_proc_id of uint32_t , Data: | ||
| // sgw_eps_bearer_context_information_s* |
There was a problem hiding this comment.
Suggested change
| // Map- Key: csr_proc_id of uint32_t , Data: | |
| // sgw_eps_bearer_context_information_s* | |
| // Map with Key: csr_proc_id of uint32_t | |
| // Data: sgw_eps_bearer_context_information_s* |
Comment on lines
92
to
98
| if (!(state_cache_p->temporary_create_session_procedure_id_map.map)) { | ||
| OAILOG_CRITICAL( | ||
| LOG_SGW_S8, | ||
| "Failed to create temporary_create_session_procedure_id_htbl for " | ||
| "Failed to create temporary_create_session_procedure_id_map for " | ||
| "SGW_S8 task \n"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
We can get rid of this check since 'new' would raise the bad_alloc exception if memory allocation fails, terminating the process.
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…edure_id to protobuf map (magma#14005)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(agw): Modified sgw_s8 code to port hash list, temporary_create_session_procedure_id to protobuf map
Test Plan
Executed only unit test suite. For in-bound roaming, End2End scenarios used to be tested in Tera VM setup. Since we are not using the Tera VM setup. We couldn't validate End2End scenario.
Additional Information
Once federated integ_test supports mocked external PGW, we can validate the End2End scenarios for inbound roaming UE