Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(agw): test-sctp-shutdown-while-mme-is-stopped.py is adapted to c… #14009

Merged
merged 1 commit into from
Sep 26, 2022
Merged

feat(agw): test-sctp-shutdown-while-mme-is-stopped.py is adapted to c… #14009

merged 1 commit into from
Sep 26, 2022

Conversation

mpfirrmann
Copy link
Contributor

…ontainerized AGW

Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com

Summary

This PR replaces the systemd specific stop and start functions for the more general enable/disable_service functions of s1ap_utils.py that can handle docker commands as well. With that we avoid starting systemd services during the execution of the test suite.

Test Plan

Additional Information

  • This change is backwards-breaking

@mpfirrmann mpfirrmann requested review from a team and pruthvihebbani September 23, 2022 15:18
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 23, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 23, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

Oops! Looks like you failed the Python Format Check.

Howto

♻️ Updated: ✅ The check is passing the Python Format Check after the last commit.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit d2fee4b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 16s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit d2fee4b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2022 •
edited

agw-workflow

615 tests   611 ✔️  4m 16s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit d2fee4b.

♻️ This comment has been updated with latest results.

@mpfirrmann mpfirrmann self-assigned this Sep 23, 2022
ssanadhya
ssanadhya approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@ssanadhya ssanadhya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpfirrmann mpfirrmann changed the title feat(agw): test_sctp_shutdown_while_mme_is_stopped.py is adapted to c… feat(agw): test-sctp-shutdown-while-mme-is-stopped.py is adapted to c… Sep 24, 2022
@mpfirrmann mpfirrmann added status: rejected ready2merge This PR is ready to be merged (is approved and passes all required checks) and removed status: rejected labels Sep 24, 2022
VinashakAnkitAman
VinashakAnkitAman requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

lte/gateway/python/integ_tests/s1aptests/test_sctp_shutdown_while_mme_is_stopped.py Outdated Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_sctp_shutdown_while_mme_is_stopped.py Show resolved Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_sctp_shutdown_while_mme_is_stopped.py Outdated Show resolved Hide resolved
@mpfirrmann mpfirrmann removed the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Sep 26, 2022
@mpfirrmann
feat(agw): test_sctp_shutdown_while_mme_is_stopped.py is adapted to c…
d2fee4b 
…ontainerized AGW

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
VinashakAnkitAman
VinashakAnkitAman approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpfirrmann mpfirrmann added the ready2merge This PR is ready to be merged (is approved and passes all required checks) label Sep 26, 2022
@VinashakAnkitAman VinashakAnkitAman merged commit ba1c9d7 into magma:master Sep 26, 2022
@mpfirrmann mpfirrmann deleted the pr/adapt_test_sctpd_shutdown branch September 26, 2022 12:26
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
@mpfirrmann @pruthvihebbani
feat(agw): test_sctp_shutdown_while_mme_is_stopped.py is adapted to c…
8e4eae8 
…ontainerized AGW (magma#14009)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssanadhya ssanadhya ssanadhya approved these changes

@VinashakAnkitAman VinashakAnkitAman VinashakAnkitAman approved these changes

@pruthvihebbani pruthvihebbani Awaiting requested review from pruthvihebbani

Assignees

@mpfirrmann mpfirrmann

Labels
component: agw Access gateway-related issue ready2merge This PR is ready to be merged (is approved and passes all required checks) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpfirrmann @ssanadhya @VinashakAnkitAman