fix(agw): fix incorrect asserts in agw integ tests #14012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
rsarwad
reviewed
Sep 27, 2022
| response.msg_type, | ||
| s1ap_types.tfwCmd.UE_CTX_REL_IND.value, | ||
| ) | ||
| assert response.msg_type == s1ap_types.tfwCmd.UE_CTX_REL_IND.value |
There was a problem hiding this comment.
The similar changes are required in other test cases, test_attach_detach_secondary_pdn_no_disconnect.py, test_attach_detach_multiple_secondary_pdn.py, test_attach_implicit_detach_timer_expiry.py, test_enb_partial_reset_multi_ue.py, test_enb_partial_reset_with_unknown_ue_s1ap_ids.py, test_secondary_pdn_reject_multiple_sessions_not_allowed_per_apn.py and many more.
There was a problem hiding this comment.
Yes, I am aware that about 100 tests or so still use self.assertEqual and similar functions instead of assert. The goal of this PR was to just fix the incorret assertTrue, where an assertEqual should have been used. A switch from the old to the new syntax in all tests will be done in a separate PR (maybe these changes here should be moved to that PR as well then?).
There was a problem hiding this comment.
nvm, I added these changes and separated them into several commits by fixing the incorrect asserts and changing the syntax
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
This commit changes * self.assertEqual and self.assertListEqual to assert ... == ... * self.assertTrue to assert * self.assertGreater to assert ... > ... * self.assertGreaterEqual to assert ... >= ... * self.assertLessEqual to assert ... <= ... * self.assertIn to assert ... in ... * self.assertIsNotNone to assert ... is not None Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
fix_wrong_asserts_in_s1ap_tests
branch
from
d567e31
to
eb8a8cf
Compare
pull-request-size
bot
added
size/XXL
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
lte/gateway/python/integ_tests/s1aptests/test_attach_detach_setsessionrules_tcp_data.py
Show resolved
Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_attach_detach_setsessionrules_tcp_data.py
Show resolved
Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_attach_detach_multiple_rar_tcp_data.py
Show resolved
Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_attach_detach_multiple_rar_tcp_data.py
Show resolved
Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_agw_offload_mixed_idle_active_multiue.py
Show resolved
Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_agw_offload_idle_active_ue.py
Show resolved
Hide resolved
lte/gateway/python/integ_tests/s1aptests/test_agw_offload_idle_active_ue.py
Show resolved
Hide resolved
Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
wolfseb
force-pushed
the
fix_wrong_asserts_in_s1ap_tests
branch
from
eb8a8cf
to
edb74fd
Compare
1 task
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
* fix(agw): fix incorrect usage of self.assertTrue Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * chore(agw): change to new pytest assert syntax This commit changes * self.assertEqual and self.assertListEqual to assert ... == ... * self.assertTrue to assert * self.assertGreater to assert ... > ... * self.assertGreaterEqual to assert ... >= ... * self.assertLessEqual to assert ... <= ... * self.assertIn to assert ... in ... * self.assertIsNotNone to assert ... is not None Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> * chore(agw): cleanup line lengths from previous commits Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com> Signed-off-by: Sebastian Wolf <sebastian.wolf@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sebastian Wolf sebastian.wolf@tngtech.com
Summary
assertTruetoassert ... == ...for response message assertsassertEqualin the touched tests to the new syntax as wellTest Plan
Run the touched integ tests
Additional Information