chore(nms): Improve generic commands functionality #14014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: nms
voisey
force-pushed
the
nms-generic-commands-improvements
branch
from
e5eed3c
to
499f929
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sebathomas
reviewed
Sep 26, 2022
voisey
force-pushed
the
nms-generic-commands-improvements
branch
2 times, most recently
from
c61d0ca
to
6aa86c4
Compare
I've addressed the linting noise and added some screenshots to the PR description. Let me know if there's anything else you'd like to see. |
sebathomas
reviewed
Sep 28, 2022
voisey
force-pushed
the
nms-generic-commands-improvements
branch
from
6aa86c4
to
a3cf7dc
Compare
orc8r/gateway/python/magma/magmad/generic_command/command_executor.py
Outdated
Show resolved
Hide resolved
orc8r/gateway/python/magma/magmad/generic_command/command_executor.py
Outdated
Show resolved
Hide resolved
voisey
force-pushed
the
nms-generic-commands-improvements
branch
2 times, most recently
from
8e7eeb0
to
bc94e1f
Compare
orc8r/gateway/python/magma/magmad/generic_command/command_executor.py
Outdated
Show resolved
Hide resolved
|
Oops! Looks like you failed the Howto
♻️ Updated: ✅ The check is passing the Python Format Check after the last commit. |
voisey
force-pushed
the
nms-generic-commands-improvements
branch
from
bc94e1f
to
8eef16b
Compare
sebathomas
reviewed
Sep 28, 2022
Work in progress, orc8r (and possibly NMS) needs to be adapted. Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
voisey
force-pushed
the
nms-generic-commands-improvements
branch
2 times, most recently
from
3305a0b
to
e24d592
Compare
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
voisey
force-pushed
the
nms-generic-commands-improvements
branch
from
e24d592
to
2e7e71c
Compare
sebathomas
approved these changes
Sep 29, 2022
1 task
This was referenced Sep 29, 2022
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
* chore(magmad): Improve error handling of generic commands
Work in progress, orc8r (and possibly NMS) needs to be adapted.
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
* Propagate Not Found error to orc8r
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Add information about configuration of generic commands
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Change default value of parameters field to use shell_params
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Handle further error cases
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
* Allow generic command to run with parameters `{"shell_params": []}`
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Signed-off-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
Co-authored-by: Sebastian Thomas <sebastian.thomas@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Builds on top of #13911. Closes #13894.
This PR:
This functionality could do with further improvements, so this is seen as a first step to make the current set-up more usable. An issue will be opened with further suggested improvements.
Test Plan
Command that is configured fails when no parameters specified
New default look
Command now works without modifying parameters field
A more helpful error is returned when a non-configured command is used
