Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(agw): sctpd needs explicit restart for docker as it is restarted … #14015

Merged
merged 2 commits into from
Sep 27, 2022
Merged

fix(agw): sctpd needs explicit restart for docker as it is restarted … #14015

merged 2 commits into from
Sep 27, 2022

Conversation

crasu
Copy link
Contributor

@crasu crasu commented Sep 26, 2022 •
edited

Summary

  • Added explicit sctpd to clear redis as with systemd the restart is triggered implictly anyway
  • Removed loop that is only run for one iteration

Test Plan

  • Ran the integ test

fix(agw): sctpd needs explicit restart for docker as it is restarted …
be07cea 
…by systemd autmatically

Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
@crasu crasu requested review from a team and rsarwad September 26, 2022 15:28
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit c36c221.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 5s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit c36c221.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 57s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit c36c221.

♻️ This comment has been updated with latest results.

@crasu crasu marked this pull request as draft September 27, 2022 06:44
fix(agw): review comments
c36c221 
Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
@crasu crasu force-pushed the pr/fix_test_attach_detach_with_corrupt_stateless_mme_for_docker branch from 4e0316f to c36c221 Compare September 27, 2022 07:42
@crasu crasu marked this pull request as ready for review September 27, 2022 07:43
VinashakAnkitAman
VinashakAnkitAman approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@VinashakAnkitAman VinashakAnkitAman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase the PR. CI check is failing.

@crasu crasu merged commit 2658f50 into magma:master Sep 27, 2022
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
@pruthvihebbani
fix(agw): sctpd needs explicit restart for docker as it is restarted … (
ec6488e 
magma#14015)

* fix(agw): sctpd needs explicit restart for docker as it is restarted by systemd autmatically

Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpfirrmann mpfirrmann mpfirrmann approved these changes

@VinashakAnkitAman VinashakAnkitAman VinashakAnkitAman approved these changes

@rsarwad rsarwad Awaiting requested review from rsarwad

Assignees
No one assigned
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crasu @mpfirrmann @VinashakAnkitAman