chore: deprecated debian stretch specific files and scripts are removed #14020

mpfirrmann · 2022-09-27T12:28:46Z

Summary

The AGW VMs now run on Ubuntu 20.04 and as the last part of the migration from Debian to Ubuntu, we purge the repo for leftover files, scripts, and comments. As part of the cleanup we ...

removed the deprecated packer templates with libvirt as VM provider
removed the deprecated packer templates based on Debian "stretch"
removed the deprecated AWS images based on Debian "stretch"
removed the deprecated Ansible role stretch_snapshot
removed the deprecated provision_stretch.sh script
removed several hints and mentions of the deprecated machines
removed the deprecated packer templates using Ubuntu 16.04 "xenial"
removed the temporary packer template that mitigated a broken OVS
removed an incomplete packer template
renamed the most recent magma-dev VM template: magma-focal-virtualbox.json -> magma-dev-virtualbox.json
removed setup.sh because all steps are included in the now used ubuntu_setup.sh
removed ansible_debian.sh due to its references to Ubuntu 14.04 "trusty"
removed the deprecated .seed file for the debian packer templates
removed several mentions of debian OS in Ansible roles
removed the unused envoy Ansible role referencing the Debian "stretch" repo of "Getenvoy.io"
removed the deprecated uselocalpkgrepo Ansible role
readability of magma-dev-virtualbox.json is improved
hints to "old" magma-focal are adapted

Closes #13969.

Test Plan

Smoke testing before merging:
Pack magma-dev VM locally
Full provision via Vagrant
-> see also issue/13566

Python unit tests
Build AGW
Run test_attach_detach and test_attach_dl_tcp_data

Additional Information

This change is backwards-breaking

github-actions · 2022-09-27T12:29:08Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-09-27T12:37:11Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit f2cb7f0.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-27T12:54:16Z

dp-workflow

14 tests 14 ✔️ 2m 10s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit f2cb7f0.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-27T13:03:13Z

cloud-workflow

1 135 tests 1 135 ✔️ 2m 59s ⏱️
  365 suites       0 💤
      7 files       0 ❌

Results for commit f2cb7f0.

♻️ This comment has been updated with latest results.

github-actions · 2022-09-27T13:16:09Z

agw-workflow

615 tests 611 ✔️ 4m 41s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit f2cb7f0.

♻️ This comment has been updated with latest results.

mpfirrmann · 2022-09-28T11:17:38Z

Grepping for stretch also gives me mentions in several other directories / files:

.cache/go/pkg/mod/github.com/docker/docker@v1.13.1/ ...
.cache/go/pkg/mod/google.golang.org/genproto@v.0.0.0-202108223120-3a666f561d7aa/ ...
ci-scripts/registry/aptly/deploy_image.sh
experimental/cloudstrapper/playbooks/roles/magma-agw/vars/main.yaml
hil_testing/Magma_Ansible/project/roles/upgrade-prep/tasks/main.yaml
nms/app/components/JsonEditor.tsx
lte/gateway/release/upgrade_magma.sh
lte/gateway/release/pydep
lte/gateway/release/deb_dependencies.bzl

I'm not quite sure what can be touched without breaking anything.

jheidbrink · 2022-10-04T11:04:07Z

orc8r/tools/packer/magma-dev-virtualbox.json

+        "scripts/ubuntu_setup.sh",
+        "scripts/vagrant_key.sh"
+      ],
+      "type": "shell"


nitpick: I find the old ordering that was based on semantics easier to understand than the new alphabetical ordering.

For example a provisioning step is easier to read for me if type comes first, followed by the most important argument to that type, like inline or script. Same for other items in the JSON hierarchy like the builders where I would also prefer having the type at the top, or having the post-processors after the provisioners which sort of reflects the order in which things are done.

Sticking to the old ordering has the additional advantage of making this diff much nicer to read ;)

Adapted. While we only renamed the .json here, I agree that a semantic ordering improves readability and leads to an easier understanding.

Thanks! And yes, I actually read the diff wrong because of the rename ;)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

…ed (magma#14020) * chore: deprecated packer templates for libvirt images are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated packer images for debian machines are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated aws images using debian are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated `stretch_snapshot` ansible role is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated `provision_stretch.sh` file is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: several deprecated debian hints are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: packer templates for Ubuntu 16.04 xenial are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: temprary packer template for broken OVS are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: incomplete packer template is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: packer script for magma-dev vm is renamed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: `setup.sh` since all steps are included in `ubuntu_setup.sh` Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: next batch of debian scripts are removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: hints to debian OS are removed from Ansible roles Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: unused `envoy` Ansible role is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: deprecated `uselocalpkgrepo` Ansible role is removed Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: readabilty of `magma-dev-virtualbox.json` is improved Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> * chore: hints to old `magma_dev_focal` are adapted Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com> Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

pull-request-size bot added the size/XL Denotes a Pull Request that changes 500-999 lines. label Sep 27, 2022

github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) component: cwf labels Sep 27, 2022

mpfirrmann self-assigned this Sep 27, 2022

mpfirrmann linked an issue Sep 27, 2022 that may be closed by this pull request

Assorted packer and dev-vm cleanups #13969

Closed

3 tasks

mpfirrmann force-pushed the pr/clean_up_packer branch from 529b104 to 93aae03 Compare September 27, 2022 14:44

pull-request-size bot added size/XXL Denotes a Pull Request that changes 1000+ lines. and removed size/XL Denotes a Pull Request that changes 500-999 lines. labels Sep 27, 2022

github-actions bot added the component: orc8r Orchestrator-related issue label Sep 27, 2022

mpfirrmann force-pushed the pr/clean_up_packer branch from 732d2cd to 74e24d7 Compare September 28, 2022 11:15

mpfirrmann requested review from sebathomas, nstng and LKreutzer September 28, 2022 12:11

sebathomas approved these changes Sep 29, 2022

View reviewed changes

mpfirrmann force-pushed the pr/clean_up_packer branch from c3e5a3e to 5b9e460 Compare September 29, 2022 16:26

mpfirrmann changed the title ~~[WIP] chore: deprecated debian stretch specific files and scripts are removed~~ chore: deprecated debian stretch specific files and scripts are removed Sep 30, 2022

mpfirrmann marked this pull request as ready for review September 30, 2022 08:12

mpfirrmann requested a review from a team September 30, 2022 08:12

mpfirrmann requested a review from a team as a code owner September 30, 2022 08:12

mpfirrmann requested review from a team and MoritzThomasHuebner September 30, 2022 08:12

sebathomas approved these changes Sep 30, 2022

View reviewed changes

jheidbrink reviewed Oct 4, 2022

View reviewed changes

mpfirrmann force-pushed the pr/clean_up_packer branch from 2b79e26 to 56c1542 Compare October 4, 2022 11:34

jheidbrink approved these changes Oct 4, 2022

View reviewed changes

mpfirrmann removed the DONOTLAND Please don't merge this label Oct 4, 2022

mpfirrmann enabled auto-merge (squash) October 4, 2022 15:37

mpfirrmann disabled auto-merge October 4, 2022 15:37

mpfirrmann added 17 commits October 4, 2022 17:38

chore: deprecated packer templates for libvirt images are removed

eee47f3

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: deprecated packer images for debian machines are removed

0a73468

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: deprecated aws images using debian are removed

851d159

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: deprecated stretch_snapshot ansible role is removed

8338dab

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: deprecated provision_stretch.sh file is removed

31a23ef

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: several deprecated debian hints are removed

7c2cf15

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: packer templates for Ubuntu 16.04 xenial are removed

5d660dc

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: temprary packer template for broken OVS are removed

b377284

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: incomplete packer template is removed

e2bb4ad

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: packer script for magma-dev vm is renamed

9105ff8

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: setup.sh since all steps are included in ubuntu_setup.sh

362dc22

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: next batch of debian scripts are removed

849113c

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: hints to debian OS are removed from Ansible roles

ee80ab9

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: unused envoy Ansible role is removed

fe592f6

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: deprecated uselocalpkgrepo Ansible role is removed

01ee656

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: readabilty of magma-dev-virtualbox.json is improved

73714c7

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

chore: hints to old magma_dev_focal are adapted

f2cb7f0

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

mpfirrmann force-pushed the pr/clean_up_packer branch from 08277d7 to f2cb7f0 Compare October 4, 2022 15:39

mpfirrmann enabled auto-merge (squash) October 4, 2022 15:39

mpfirrmann disabled auto-merge October 4, 2022 16:06

mpfirrmann enabled auto-merge (squash) October 4, 2022 16:07

mpfirrmann merged commit 79a196a into magma:master Oct 4, 2022

mpfirrmann deleted the pr/clean_up_packer branch October 14, 2022 06:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: deprecated debian stretch specific files and scripts are removed #14020

chore: deprecated debian stretch specific files and scripts are removed #14020

mpfirrmann commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022

github-actions bot commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited

mpfirrmann commented Sep 28, 2022

jheidbrink Oct 4, 2022

mpfirrmann Oct 4, 2022

jheidbrink Oct 4, 2022

chore: deprecated debian stretch specific files and scripts are removed #14020

chore: deprecated debian stretch specific files and scripts are removed #14020

Conversation

mpfirrmann commented Sep 27, 2022 • edited

Summary

Test Plan

Additional Information

github-actions bot commented Sep 27, 2022

Howto

More info

github-actions bot commented Sep 27, 2022 • edited

feg-workflow

github-actions bot commented Sep 27, 2022 • edited

dp-workflow

github-actions bot commented Sep 27, 2022 • edited

cloud-workflow

github-actions bot commented Sep 27, 2022 • edited

agw-workflow

mpfirrmann commented Sep 28, 2022

jheidbrink Oct 4, 2022

Choose a reason for hiding this comment

mpfirrmann Oct 4, 2022

Choose a reason for hiding this comment

jheidbrink Oct 4, 2022

Choose a reason for hiding this comment

mpfirrmann commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited

github-actions bot commented Sep 27, 2022 •

edited