refactor(orc8r): Remove proto.Clone calls #14029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
MoritzThomasHuebner
changed the title
- Remove proto.Clone calls from sql.go - Added some missing commas to comments - Changed empty slice creation using literals to nil slice declaration Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
MoritzThomasHuebner
force-pushed
the
remove_proto_clone_calls
branch
from
d3146d3
to
3cd4e74
Compare
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
…rs.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
* refactor(orc8r): Minor improvements to sql.go - Remove proto.Clone calls from sql.go - Added some missing commas to comments - Changed empty slice creation using literals to nil slice declaration Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Remove proto.Clone calls from sql_test.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Remove proto.Clone calls from client_api.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Remove proto.Clone calls from sql_entity_write_helpers.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Remove proto.Clone calls from storage.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Remove proto.Clone calls from sql_integ_test.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Revert changes in sql_integ_test.go Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> * refactor(orc8r): Revert changes to import order Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com> Signed-off-by: Moritz Huebner <moritz.huebner@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13698
Summary
proto.Clonecalls from the orc8r by passing references.Test Plan
Run unit tests.
Additional Information
The remaining uses of
proto.Clonein the orc8r are necessary.I also checked occurrences of
proto.Clonein the FeG, but these all appear to be required.