Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use correct variable offered by dispatch action #14038

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

ajahl
Copy link
Contributor

@ajahl ajahl commented Sep 29, 2022

Signed-off-by: Alex Jahl alexander.jahl@tngtech.com

Summary

#13983 uses a the wrong environment variable. The result is that the lte-integ-test-magma-deb workflow always install the latest magma package version in the magma debian vm.

client-payload: '{ "artifact": "${{ needs.agw-build.outputs.magma_package }}" }'

MAGMA_PACKAGE: ${{ github.event.client_payload.magma_package }}

The lte-integ-test-magma-deb workflow uses magma_package in line 57 but needs artifact which is define in build-all in line 1014.

Test Plan

Can only be seen on the magma master branch after the PR is merged and the agw-build job in build-all run through.

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 29, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 7b6e3f7.

@ajahl ajahl marked this pull request as ready for review September 29, 2022 13:38
@ajahl ajahl requested a review from a team as a code owner September 29, 2022 13:38
@ajahl ajahl requested a review from maxhbr September 29, 2022 13:38
@voisey voisey requested a review from nstng September 29, 2022 14:09
@ajahl ajahl merged commit c30befd into magma:master Sep 29, 2022
@ajahl ajahl linked an issue Sep 30, 2022 that may be closed by this pull request
5 tasks
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run integration tests against debian installation in CI
2 participants