Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cache key of bazel base and image tag are updated #14041

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Sep 29, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

Closes #13818.

Last step of aligning folly in the vm and in the bazel base image. See https://github.com/magma/magma/wiki/Bazel-remote-caching#solving-breaking-changes-in-remote-caches for a detailed description.

Note: already filled caches from a local setup for bazel-base-image-sha-c4de1e5.

Test Plan

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Sep 29, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 9bc29f3.

♻️ This comment has been updated with latest results.

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng force-pushed the update_cache_key_and_bazel_base_image branch from 4612dd8 to 9bc29f3 Compare September 29, 2022 15:28
@nstng nstng linked an issue Sep 29, 2022 that may be closed by this pull request
@nstng nstng marked this pull request as ready for review September 29, 2022 15:31
@nstng nstng requested a review from a team September 29, 2022 15:31
@nstng nstng requested a review from a team as a code owner September 29, 2022 15:31
@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  4m 46s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 9bc29f3.

@nstng nstng requested review from vktng and removed request for jheidbrink September 30, 2022 07:46
Copy link
Contributor

@vktng vktng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nstng nstng added the DONOTLAND Please don't merge this label Sep 30, 2022
@nstng
Copy link
Contributor Author

nstng commented Sep 30, 2022

Set DONOTLAND for now - last time this change broke CI. This time I am confident that it will work, but I prefer to merge this next week in order to monitor it and react fast if something breaks.

@nstng nstng removed the DONOTLAND Please don't merge this label Oct 4, 2022
@nstng nstng merged commit a231e46 into magma:master Oct 4, 2022
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

folly is aligned in bazel base and magma vm
3 participants