-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cache key of bazel base and image tag are updated #14041
chore: cache key of bazel base and image tag are updated #14041
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
4612dd8
to
9bc29f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Set DONOTLAND for now - last time this change broke CI. This time I am confident that it will work, but I prefer to merge this next week in order to monitor it and react fast if something breaks. |
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
Closes #13818.
Last step of aligning folly in the vm and in the bazel base image. See https://github.com/magma/magma/wiki/Bazel-remote-caching#solving-breaking-changes-in-remote-caches for a detailed description.
Note: already filled caches from a local setup for
bazel-base-image-sha-c4de1e5
.Test Plan
Additional Information