-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pip performance is improved by ipv4 over ipv6 precedence #14057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
Access gateway-related issue
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
labels
Sep 30, 2022
tmdzk
approved these changes
Oct 4, 2022
sebathomas
approved these changes
Oct 4, 2022
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
…a#14057) Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com> Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: agw
Access gateway-related issue
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
size/M
Denotes a PR that changes 30-99 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
There is no ipv6 interface defined on the vms that is able to do external communication. Various tools (also pip) use getaddrinfo for communication with a service. This has per default an ipv6 preference. If ipv6 endpoints are not reachable then this can take much longer than needed.
Here: change to an ipv4 over ipv6 preference.
To reproduce:
time pip3 install pip-install-test
with and without this change (can be done without sourcing or restarting)real 0m13.822s
vsreal 0m1.707s
Note: there might be a better way to configure the network interfaces of the VMs - until now I did not find a more clean way.
Test Plan
Make sure no integration test depends on an ipv6 preference:
Additional Information