Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable manual execution of the integ test magma_deb in ci #14076

Merged

Conversation

ajahl
Copy link
Contributor

@ajahl ajahl commented Oct 4, 2022

Signed-off-by: Alex Jahl alexander.jahl@tngtech.com

Summary

The PR fixes an issues where the Task [magma_deb : Install magma] fails when the lte integ test for magma_deb is triggered by hand in the CI. The reason is that the env variable that holds the debian magma package version is empty.
Now a default is used when the env variable is empty or not defined.

Test Plan

  • build magma_deb locally
  • run lte integ test magma_deb workflow in CI

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit c9c5870.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

dp-workflow

14 tests   14 ✔️  2m 5s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit c9c5870.

♻️ This comment has been updated with latest results.

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
@ajahl ajahl force-pushed the enable_manual_integ_test_magma_deb_ci_run branch from 21f7f45 to c9c5870 Compare October 4, 2022 10:18
@ajahl ajahl marked this pull request as ready for review October 4, 2022 10:18
@ajahl ajahl requested a review from a team as a code owner October 4, 2022 10:18
@ajahl ajahl requested a review from koolzz October 4, 2022 10:18
@nstng nstng self-requested a review October 4, 2022 11:18
Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for the fix!

@voisey voisey merged commit 12029dc into magma:master Oct 4, 2022
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
…agma#14076)

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>

Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants