-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): enable manual execution of the integ test magma_deb in ci #14076
Merged
voisey
merged 1 commit into
magma:master
from
ajahl:enable_manual_integ_test_magma_deb_ci_run
Oct 4, 2022
Merged
chore(ci): enable manual execution of the integ test magma_deb in ci #14076
voisey
merged 1 commit into
magma:master
from
ajahl:enable_manual_integ_test_magma_deb_ci_run
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
ajahl
force-pushed
the
enable_manual_integ_test_magma_deb_ci_run
branch
from
October 4, 2022 10:18
21f7f45
to
c9c5870
Compare
nstng
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you for the fix!
voisey
approved these changes
Oct 4, 2022
pruthvihebbani
pushed a commit
to pruthvihebbani/magma
that referenced
this pull request
Oct 10, 2022
…agma#14076) Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com> Signed-off-by: Alex Jahl <alexander.jahl@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Jahl alexander.jahl@tngtech.com
Summary
The PR fixes an issues where the Task
[magma_deb : Install magma]
fails when the lte integ test for magma_deb is triggered by hand in the CI. The reason is that the env variable that holds the debian magma package version is empty.Now a default is used when the env variable is empty or not defined.
Test Plan