fix(agw): Converted s6a task files to cpp

[VinashakAnkitAman]

Title

fix(agw): Converted s6a task files to cpp [Extension to Github Issue: #13096]

Summary

Migrated all the files related to s6a task in the folders magma/lte/gateway/c/core/oai/tasks/s6a/ and magma/lte/gateway/c/core/oai/include/ to cpp/hpp and fixed all the compilation errors and warnings.

Note: The function fd_msg_browse() is a macro function expanding to fd_msg_browse_internal() in the file /usr/local/include/freeDiameter/libfdproto.h, which passes the 3rd argument of function by casting to (void *), but received as (msg_or_avp **). This is failing with c++ explicit typecasting validation. To fix this all the fd_msg_browse() calls have been shifted to fd_msg_browse_internal() function calls to avoid intermediate type conversion by the macro and the 3rd argument is now passed as typecasted value to (msg_or_avp **)

For reference: https://github.com/Metaswitch/freeDiameter/blob/master/include/freeDiameter/libfdproto.h#:~:text=int%20fd_msg_browse_internal%20(%20msg_or_avp,*)(found)%2C%20(depth)%20)

Also followed the guidelines for order of headers from https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

Test plan

Verified compilation with following:
make clean; make build_oai;
make clean; make test_oai;
make clean; make test_oai BUILD_TYPE=Debug OAI_TESTS=test_amf_app
make clean; bazel build --config=production //lte/gateway/c/core:agw_of
make clean; bazel test //lte/gateway/c/core/oai/test/amf:amf_stateless_test
make clean; make FEATURES=mme_oai build_oai
make clean; export FEATURES=mme_oai; make build_oai

Verified with sanity and in CI

Note: After using FEATURES=mme_oai; flag, make test_oai started failing in spgw module with undefined reference to some config functions. Needed to exit out from the VM and re-login to fix the issue.

Signed-off-by: VinashakAnkitAman ankit.aman@radisys.com

[github-actions]

Thanks for opening a PR! 💯

A couple initial guidelines

• All commits must be signed off. This is enforced by DCO check.
• All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

• Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
• Checks. All required CI checks must pass before merge.
• Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

• Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

• Developer Onboarding for onboarding as a new Magma developer
• Development Workflow for guidance on your first pull request
• CI Checks for points of contact for failing or flaky CI checks
• GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

[github-actions]

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 316095a.

♻️ This comment has been updated with latest results.

[github-actions]

dp-workflow

14 tests   14 ✔️  2m 13s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 316095a.

♻️ This comment has been updated with latest results.

[github-actions]

agw-workflow

615 tests   611 ✔️  3m 52s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 316095a.

♻️ This comment has been updated with latest results.

[ssanadhya]

Minor comments.

Please add in summary why you need to use fd_msg_browse_internal and make sure that Magma-OAI-Jenkins CI check is passing with this change.

[ssanadhya]

Lgtm, can be merged once @rsarwad approves.

[LKreutzer]

Bazel changes lgtm

[rsarwad]

LGTM