Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vagrant box cache location is pointing to correct folder #14092

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Oct 6, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

Problem:

Run actions/cache@0865c47f36e68161719c5b124609996bb5c40129
  with:
    path: ~/.vagrant.d/boxes/magmacore-VAGRANTSLASH-magma_deb
    key: vagrant-box-magma-deb-focal64-20220804.0.0
Cache not found for input keys: vagrant-box-magma-deb-focal64-20220804.0.0
  • Post cache magma-deb-box
Post job cleanup.
Warning: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.

Solution:

  • the correct path should be ~/.vagrant.d/boxes/ubuntu-VAGRANTSLASH-focal64 - the name of the base image used

Test Plan

CI run on fork: https://github.com/nstng/magma/actions/runs/3196079738

  • Post cache magma-deb-box
Cache saved successfully
Cache saved with key: vagrant-box-magma-deb-focal64-20220804.0.0

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@nstng nstng requested a review from a team as a code owner October 6, 2022 09:25
@nstng nstng requested a review from talkhasib October 6, 2022 09:25
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 67f8f54.

@nstng nstng requested a review from ajahl October 6, 2022 09:32
@nstng nstng merged commit a586181 into magma:master Oct 7, 2022
pruthvihebbani pushed a commit to pruthvihebbani/magma that referenced this pull request Oct 10, 2022
…14092)

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants