Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integ test workflows are reproducible #14097

Merged

Conversation

nstng
Copy link
Contributor

@nstng nstng commented Oct 6, 2022

Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com

Summary

NOTE: The reasoning for this change might be subjective! If you have a strong opinion to not do this change, then please comment on this issue.

The integ tests workflows (make and bazel) are doing an apt dist-upgrade on the magma dev VM ...

  • inconsistent: this is only happening on the magma vm - not on magma_test or magma_trfserver (yes, the magma vm is here more relevant, but this is still inconsistent)
  • not reproducible: this can make the tests less reproducible as different versions (packages and kernel) might influence results
  • runtime: after a fresh pre-burn image is released this step is not doing much - after some time it takes a couple of minutes
    • -> we should aim for more frequent releases of pre-burn images

Test Plan

Make sure the tests still run without a dist-upgrade - runs on fork:

Additional Information

  • This change is backwards-breaking

Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 6, 2022
@nstng nstng linked an issue Oct 6, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 6aa1d5c.

@nstng nstng marked this pull request as ready for review October 6, 2022 12:03
@nstng nstng requested a review from a team as a code owner October 6, 2022 12:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

dp-workflow

14 tests   14 ✔️  2m 8s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 6aa1d5c.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

agw-workflow

615 tests   611 ✔️  4m 56s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 6aa1d5c.

@nstng nstng merged commit e221374 into magma:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the Bazel local setup more comfortable
3 participants