fix(agw): Modified code at s1ap to remove dependency on common state manager class #14116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…tion_10869 Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…_c_to_cpp Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…tion_10869 Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…_c_to_cpp Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into rsarwad_s1ap_integrate_proto_map Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into rsarwad_s1ap_integrate_proto_map
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into rsarwad_s1ap_integrate_proto_map Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…_c_to_cpp Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into rsarwad_s1ap_integrate_proto_map
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…tion_10869 Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…tion_10869 Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…odule Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…tion_10869 Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ntext Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…agma into rsarwad_move_s1ap_state_ctx Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…_state_ctx Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…_state_ctx Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…manager class Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
pull-request-size
bot
added
the
size/L
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include "lte/gateway/c/core/oai/common/conversions.h" | ||
| #include "lte/gateway/c/core/oai/common/redis_utils/redis_client.hpp" | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Do not use unnamed namespaces in header files. See https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Namespaces for more information. [build/namespaces_headers] [4]
There was a problem hiding this comment.
@rsarwad Can you fix it, please?
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
11192_rsarwad
branch
from
3221a75
to
c678cc9
Compare
ssanadhya
reviewed
Oct 27, 2022
| @@ -129,15 +128,15 @@ TEST_F(S1APStateConverterTest, S1apStateConversionExpectedEnbCount) { | |||
| enb_map.map = init_state->mutable_enbs(); | |||
| // Inserting 1 enb association | |||
| enb_map.insert(enb_association.sctp_assoc_id(), enb_association); | |||
| // state_to_proto should update num_enbs to match expected eNB count on the | |||
| // map | |||
| // Write the state info to DB and should update num_enbs to match expected eNB | |||
There was a problem hiding this comment.
Suggested change
| // Write the state info to DB and should update num_enbs to match expected eNB | |
| // Write the state info to DB and update num_enbs to match expected eNB |
ssanadhya
approved these changes
Oct 27, 2022
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
…manager class (magma#14116) fix(agw): Modified code at s1ap to remove dependency on common state manager class Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(agw): Modified code at s1ap to remove dependency on common state manager class
In this PR, new class StateUtility is added that contains common state variables and function which shall be used across various tasks like s1ap, mme_app and spgw task
This PR partially addresses the issue, #11192
Test Plan
Executed s1ap sanity test suite and unit test cases