Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove deprecated fabfile test option #14117

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Oct 10, 2022

and this for over a year now

I did a full text search for fab test as well as fab .* test and could not find any active usages with that.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 10, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 10, 2022
@Neudrino Neudrino marked this pull request as ready for review October 10, 2022 15:49
@Neudrino Neudrino requested a review from a team as a code owner October 10, 2022 15:49
@Neudrino Neudrino requested a review from koolzz October 10, 2022 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 6e5bbbf.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2022

dp-workflow

14 tests   14 ✔️  2m 14s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 6e5bbbf.

♻️ This comment has been updated with latest results.

Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

agw-workflow

473 tests   468 ✔️  2m 36s ⏱️
    1 suites      4 💤
    1 files        1

For more details on these failures, see this check.

Results for commit d332dd4.

@Neudrino Neudrino requested review from voisey and ajahl October 10, 2022 17:03
Copy link
Contributor

@voisey voisey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment at the top of the file, specifically lines 36 and 37, should be modified to reflect the switch from test to release.

@Neudrino Neudrino changed the title chore(ci): the fabfile test option is deprecated chore(ci): remove deprecated fabfile test option Oct 11, 2022
@Neudrino Neudrino force-pushed the ci/remove-deprecated-fab-command branch from d332dd4 to 024b2a1 Compare October 11, 2022 13:29
and this for over a year now

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/remove-deprecated-fab-command branch from 024b2a1 to 6e5bbbf Compare October 11, 2022 13:29
@Neudrino Neudrino requested a review from voisey October 11, 2022 13:30
@Neudrino Neudrino enabled auto-merge (squash) October 11, 2022 13:33
@Neudrino Neudrino merged commit 7c83fc5 into magma:master Oct 11, 2022
@Neudrino Neudrino deleted the ci/remove-deprecated-fab-command branch October 11, 2022 14:20
@Neudrino Neudrino self-assigned this Oct 14, 2022
@Neudrino Neudrino linked an issue Oct 14, 2022 that may be closed by this pull request
@Neudrino Neudrino removed their assignment Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
3 participants