Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Containerized AGW integ test #14138

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

crasu
Copy link
Contributor

@crasu crasu commented Oct 12, 2022

Health check in containerized integ ci job (#13695) fails because the container is not healthy after the first docker compose up command.

Summary

Without this change the oai_mme container sometimes gets unhealthy as it needs more time than 12s for startup.

Test Plan

Integ test run: https://github.com/crasu/magma/actions/runs/3233203515/jobs/5294753054

…althy after the first docker compose up command

Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
@crasu crasu requested a review from a team October 12, 2022 08:30
@crasu crasu requested a review from a team as a code owner October 12, 2022 08:30
@crasu crasu requested a review from tmdzk October 12, 2022 08:30
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 12, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 12, 2022
@crasu crasu changed the title fix(ci): fix(ci): Containerized AGW integ test Oct 12, 2022
Copy link
Contributor

@wolfseb wolfseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 1e7dff5.

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 8s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 1e7dff5.

Copy link
Contributor

@nstng nstng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  5m 6s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 1e7dff5.

@crasu crasu merged commit 3fe3e7d into magma:master Oct 12, 2022
@crasu crasu deleted the pr/fix-health-check-for-containerized-ci branch October 12, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants