-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Containerized AGW integ test #14138
Merged
crasu
merged 1 commit into
magma:master
from
crasu:pr/fix-health-check-for-containerized-ci
Oct 12, 2022
Merged
fix(ci): Containerized AGW integ test #14138
crasu
merged 1 commit into
magma:master
from
crasu:pr/fix-health-check-for-containerized-ci
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…althy after the first docker compose up command Signed-off-by: Christian Krämer <christian.kraemer@tngtech.com>
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
label
Oct 12, 2022
wolfseb
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
alexzurbonsen
approved these changes
Oct 12, 2022
nstng
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: ci
All updates on CI (Jenkins/CircleCi/Github Action)
size/XS
Denotes a PR that changes 0-9 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Health check in containerized integ ci job (#13695) fails because the container is not healthy after the first docker compose up command.
Summary
Without this change the oai_mme container sometimes gets unhealthy as it needs more time than 12s for startup.
Test Plan
Integ test run: https://github.com/crasu/magma/actions/runs/3233203515/jobs/5294753054