Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): abstract environment preparation #14151

Merged

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Oct 13, 2022

Summary

...as this is the same for all targets

⚠️ The diff looks ugly! Essentially added lines 39-41 and used the target for all below.

Test Plan

  • CI

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

feg-workflow

    2 files  203 suites   39s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit cfe844e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

dp-workflow

14 tests   14 ✔️  2m 23s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit cfe844e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  4m 20s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit dabbe48.

as this is the same for all targets

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKII branch from dabbe48 to cfe844e Compare October 14, 2022 13:51
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 14, 2022
@Neudrino Neudrino marked this pull request as ready for review October 14, 2022 13:54
@Neudrino Neudrino requested a review from a team October 14, 2022 13:54
@Neudrino Neudrino enabled auto-merge (squash) October 14, 2022 13:54
@Neudrino Neudrino merged commit c22ced0 into magma:master Oct 14, 2022
@Neudrino Neudrino deleted the ci/refactor-integration-test-makefile-MKII branch October 14, 2022 14:52
@Neudrino Neudrino linked an issue Oct 14, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
2 participants