Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): allow more granular AGW integration test execution #14158

Merged

Conversation

Neudrino
Copy link
Contributor

Summary

Changing from a toggle to a keyword for different test scenarios gives much more flexibility for further extension. Those extension capabilities are needed for the more granular management of test cases in the context of integration test implementation for containerized AGW.

Test Plan

  • CI

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 13, 2022
@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKV branch from e2f7c41 to 850b5da Compare October 13, 2022 16:11
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 13, 2022
@Neudrino Neudrino requested review from voisey and ajahl October 13, 2022 16:13
@Neudrino Neudrino marked this pull request as ready for review October 13, 2022 16:13
@Neudrino Neudrino requested a review from a team as a code owner October 13, 2022 16:13
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKV branch from 850b5da to 9a7eaf2 Compare October 13, 2022 16:19
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 13, 2022
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKV branch from 9a7eaf2 to d7517ee Compare October 13, 2022 16:23
@Neudrino Neudrino enabled auto-merge (squash) October 13, 2022 16:24
@github-actions
Copy link
Contributor

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit d7517ee.

@github-actions
Copy link
Contributor

dp-workflow

14 tests   14 ✔️  2m 12s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit d7517ee.

@github-actions
Copy link
Contributor

agw-workflow

615 tests   611 ✔️  3m 47s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit d7517ee.

@Neudrino Neudrino merged commit 7a893dc into magma:master Oct 14, 2022
@Neudrino Neudrino deleted the ci/refactor-integration-test-makefile-MKV branch October 14, 2022 11:58
@Neudrino Neudrino linked an issue Oct 14, 2022 that may be closed by this pull request
@Neudrino Neudrino removed their assignment Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
2 participants