fix: correct action for macos slack notification is used #14163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nils Semmelrock <nils.semmelrock@tngtech.com>
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
the
component: ci
tmdzk
approved these changes
Oct 13, 2022
maxhbr
reviewed
Oct 14, 2022
| if: failure() && github.event_name == 'push' && github.repository_owner == 'magma' | ||
| uses: rtCamp/action-slack-notify@12e36fc18b0689399306c2e0b3e0f2978b7f1ee7 # pin@v2.2.0 | ||
| if: failure() && github.repository_owner == 'magma' | ||
| uses: Ilshidur/action-slack@689ad44a9c9092315abd286d0e3a9a74d31ab78a # pin@2.1.0 |
There was a problem hiding this comment.
Ilshidur/action-slack seems to be way less maintained and less popular as rtCamp/action-slack-notify
There was a problem hiding this comment.
used by 600 compared to used by 8k
There was a problem hiding this comment.
Yes, but rtCamps action does not work on macos runners.
There was a problem hiding this comment.
OK, was just surprised and thought it would be wroth asking,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nils Semmelrock nils.semmelrock@tngtech.com
Summary
In #14093 a macos based workflow was introduced that sends a slack notification in case of failure. I used an action that only works on ubuntu based workflows. For review: compare with slack action used established macos workflows.
See notification send failure on: https://github.com/magma/magma/actions/runs/3242702815/jobs/5316352859
Error: Container action is only supported on Linux.Test Plan
CI
Additional Information