Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): directory not used at all in federated integration tests #14169

Conversation

Neudrino
Copy link
Contributor

Summary

The created directory is not used at all afterwards.

Test Plan

  • Full text search for the directory in the codebase.
  • CI

Additional information

  • CI of federated integration tests seems to be overall flaky because often the respective machines do not start properly.

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 14, 2022
@Neudrino Neudrino self-assigned this Oct 14, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 14, 2022
@Neudrino Neudrino marked this pull request as ready for review October 14, 2022 10:23
@Neudrino Neudrino requested a review from a team as a code owner October 14, 2022 10:23
@Neudrino Neudrino requested a review from nstng October 14, 2022 10:23
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit fb36b4e.

@Neudrino Neudrino merged commit 67bd80c into magma:master Oct 14, 2022
@Neudrino Neudrino deleted the ci/clean-unused-command-in-federated-integration-test branch October 14, 2022 13:33
@Neudrino Neudrino linked an issue Oct 14, 2022 that may be closed by this pull request
@Neudrino Neudrino removed their assignment Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
2 participants