Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nms): Fix fetching of subscriber config for paginated subscribers #14172

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

voisey
Copy link
Contributor

@voisey voisey commented Oct 14, 2022

Summary

Closes #13506 by implementing the fallback mechanism that is present in SubscriberDetail to SubscriberDetailConfig

Test Plan

  • Reproduced the bug locally, then verified that with this fix, refreshing the subscriber config page for subscribers not on the first page doesn't lead to an error
  • CI

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 14, 2022
@github-actions github-actions bot added the component: nms NMS-related issue label Oct 14, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit d5d2bab.

♻️ This comment has been updated with latest results.

Signed-off-by: Cameron Voisey <cameron.voisey@tngtech.com>
@voisey voisey force-pushed the nms-subscriber-config-refresh-bug branch from 8d9895c to d5d2bab Compare October 14, 2022 11:18
@github-actions
Copy link
Contributor

nms-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit d5d2bab.

@voisey voisey marked this pull request as ready for review October 14, 2022 13:15
@voisey voisey requested review from a team and Neudrino October 14, 2022 13:15
@magma magma deleted a comment from github-actions bot Oct 14, 2022
@voisey voisey merged commit 888bef5 into magma:master Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: nms NMS-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NMS] Subscriber edit page error after reload
2 participants